Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch bun repo to use bun.lock #16324

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Switch bun repo to use bun.lock #16324

wants to merge 4 commits into from

Conversation

pfgithub
Copy link
Contributor

What does this PR do?

Might require updating the bun version in CI

@robobun
Copy link

robobun commented Jan 11, 2025

Updated 1:22 AM PT - Jan 11th, 2025

@RiskyMH, your commit c077bd7 has passed in #9456! 🎉


🧪   try this PR locally:

bunx bun-pr 16324

@fel1x-developer
Copy link
Contributor

We need to add following to bunfig.toml (source) at least until we release v1.2.0

[install]
saveTextLockfile = true

@RiskyMH
Copy link
Member

RiskyMH commented Jan 11, 2025

We need to add following to bunfig.toml (source) at least until we release v1.2.0

[install]
saveTextLockfile = true

I'm not sure why everyone is adding this on their updates, but if bun sees bun.lock it will update/use it. Only time this config would be used is if you delete file and want to make again.

@fel1x-developer
Copy link
Contributor

fel1x-developer commented Jan 11, 2025

We need to add following to bunfig.toml (source) at least until we release v1.2.0

[install]
saveTextLockfile = true

I'm not sure why everyone is adding this on their updates, but if bun sees bun.lock it will update/use it. Only time this config would be used is if you delete file and want to make again.

This can prevent situations where a developer accidently deletes bun.lock and executes bun install. Even though we can correct wrong lockfiles in PR review stage, adding these two lines makes reviews simpler and more efficient.

Edit: grammar

@@ -19,6 +19,7 @@
*.mts text eol=lf whitespace=blank-at-eol,-blank-at-eof,-space-before-tab,tab-in-indent,tabwidth=2

*.lockb binary diff=lockb
bun.lock linguist-language=json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added as temporary measure as it makes the files look better (wait until github-linguist/linguist#7193 and then can remove)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants