PR feedback from #15865

oven-sh · Dec 19, 2024 · 42f23f0 · 42f23f0
1 parent ac6723e
commit 42f23f0
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/bun.js/bindings/NodeVM.cpp b/src/bun.js/bindings/NodeVM.cpp
@@ -200,7 +200,6 @@ bool NodeVMGlobalObject::put(JSCell* cell, JSGlobalObject* globalObject, Propert
     }
     RETURN_IF_EXCEPTION(scope, false);
 
-    slot.setThisValue(sandbox);
     if (isDeclaredOnSandbox && getter.isAccessor() and (getter.attributes() & PropertyAttribute::DontEnum) == 0) {
         return true;
     }
@@ -553,8 +552,10 @@ JSC_DEFINE_HOST_FUNCTION(vmModuleRunInNewContext, (JSGlobalObject * globalObject
     NakedPtr<Exception> exception;
     JSValue result = JSC::evaluate(context, sourceCode, context, exception);
 
-    if (exception)
+    if (exception) {
         throwException(globalObject, scope, exception);
+        return {};
+    }
 
     return JSValue::encode(result);
 }