Select when updated #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be an user action, not something automatically run on install. We're using ui-select in a browserify project, and we don't need/have bower installed. Furthermore it pollutes the development folder with an unused bower_components.
Resolves angular-ui#1032 by hiding the element with opacity, not visibility. Elements with an opacity of 0 can still be focused.
… placeholder_bug
…ivate Use opacity, not visibility to hide element
Fix jshint warnings in tests (mostly semicolons)
… placeholder_bug
… limit_multi_select
Do not run bower after install automatically
avoid errors when $select.selected is null
Limit the maximum number of selections allowed in multiple mode
Move ‘var keys = Object.keys(props);’ outside of the items.forEach(…) loop. As previously written, keys will be re-instantiated on every iteration of the forEach loop.
As scope() isn't available when debug info is disabled, use controller() to retrieve a controller from an element Fixes angular-ui#872
Solving bug when selectItems is undefined.
Protect against empty selection causing exception when getting placeHolder
chore(code clean-up): optimize propsFilter
fix(uiSelect): typing goes on last focused component
feat(choices): use object as source iterating over its properties
…ff-attr fix(templates): autocomplete off to false
…-css refactor(choices): avoid setting activeItem on mouseenter
…wn-pos feat(choices): allow to set default dropdown position
…reate Create CHANGELOG.md
…on' when not using (key,value) syntax
Fix for v0.13.0
remove hardcoded $scope.peopleObj
add input id to search <input> if present on ui-select directive as input-id
Fixes angular-ui#1208 matching and hardcoded value
make highlight filter work with numeric items
Avoid inline execution of javascript in choices template.
only when the condition is filled the select will change value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded ui-select from upstream ui-select/ui-select and added the ability to use "select-when" in the markup instead of "on-select"
when you use select-when the method supplied should return a promise, when resolved the select will be selected and rejected the select will NOT change!!!