Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to set operating mode at init_client #629

Merged
merged 7 commits into from
Dec 18, 2024

Conversation

BlaiseLebreton
Copy link
Contributor

Related Issues & PRs

None

Summary of Changes

Modified the init_client function that connects and configures a sensor to allow to set the operating_mode at boot and not have a forced OPERATING_NORMAL

Validation

Running tests...
Test project /home/blebreton/svn/rtp/external/ouster-sdk/build/Release
      Start  1: osf_png_tools_test
 1/25 Test  #1: osf_png_tools_test ...............   Passed    2.49 sec
      Start  2: osf_writer_test
 2/25 Test  #2: osf_writer_test ..................   Passed    3.03 sec
      Start  3: osf_writerv2_test
 3/25 Test  #3: osf_writerv2_test ................   Passed    0.39 sec
      Start  4: osf_writer_custom_test
 4/25 Test  #4: osf_writer_custom_test ...........   Passed    0.00 sec
      Start  5: osf_file_test
 5/25 Test  #5: osf_file_test ....................   Passed    0.01 sec
      Start  6: osf_crc_test
 6/25 Test  #6: osf_crc_test .....................   Passed    0.00 sec
      Start  7: osf_file_ops_test
 7/25 Test  #7: osf_file_ops_test ................   Passed    0.00 sec
      Start  8: osf_reader_test
 8/25 Test  #8: osf_reader_test ..................   Passed    0.01 sec
      Start  9: osf_operations_test
 9/25 Test  #9: osf_operations_test ..............   Passed    0.03 sec
      Start 10: osf_basics_test
10/25 Test #10: osf_basics_test ..................   Passed    0.00 sec
      Start 11: osf_meta_streaming_info_test
11/25 Test #11: osf_meta_streaming_info_test .....   Passed    0.00 sec
      Start 12: bcompat_meta_json_test
12/25 Test #12: bcompat_meta_json_test ...........   Passed    0.07 sec
      Start 13: metadata_test
13/25 Test #13: metadata_test ....................   Passed    0.06 sec
      Start 14: lidar_scan_test
14/25 Test #14: lidar_scan_test ..................   Passed    0.07 sec
      Start 15: cartesian_test
15/25 Test #15: cartesian_test ...................   Passed    8.73 sec
      Start 16: metadata_errors_test
16/25 Test #16: metadata_errors_test .............   Passed    0.01 sec
      Start 17: pcap_test
17/25 Test #17: pcap_test ........................   Passed    0.06 sec
      Start 18: profile_extension_test
18/25 Test #18: profile_extension_test ...........   Passed    0.00 sec
      Start 19: fusa_profile_test
19/25 Test #19: fusa_profile_test ................   Passed    0.01 sec
      Start 20: parsing_benchmark_test
20/25 Test #20: parsing_benchmark_test ...........   Passed   16.69 sec
      Start 21: scan_batcher_test
21/25 Test #21: scan_batcher_test ................   Passed    0.25 sec
      Start 22: packet_writer_test
22/25 Test #22: packet_writer_test ...............   Passed    0.23 sec
      Start 23: array_view_test
23/25 Test #23: array_view_test ..................   Passed    0.56 sec
      Start 24: field_test
24/25 Test #24: field_test .......................   Passed    0.14 sec
      Start 25: point_viz_test
25/25 Test #25: point_viz_test ...................   Passed    0.00 sec

100% tests passed, 0 tests failed out of 25

Total Test time (real) =  32.85 sec

@BlaiseLebreton BlaiseLebreton marked this pull request as draft November 29, 2024 09:10
@BlaiseLebreton BlaiseLebreton marked this pull request as ready for review November 29, 2024 09:17
Copy link
Collaborator

@matthew-lidar matthew-lidar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good change overall! If you can move the argument and clean up the incidental whitespace changes to minimize the diff, should be good.

ouster_client/include/ouster/client.h Outdated Show resolved Hide resolved
@BlaiseLebreton
Copy link
Contributor Author

Looks like a good change overall! If you can move the argument and clean up the incidental whitespace changes to minimize the diff, should be good.

Added a few commits to resolve your remarks, let me know !
All tests are passing

@BlaiseLebreton
Copy link
Contributor Author

Is there anything to do on my end to solve this blocking check ?

@Samahu Samahu self-requested a review December 18, 2024 21:52
@matthew-lidar matthew-lidar merged commit 8495190 into ouster-lidar:master Dec 18, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants