FW 2.5 Release tweaks (#503)

* help message for simple-viz * disable fps warning
ouster-lidar · Apr 3, 2023 · d730798 · d730798
1 parent 9a81b1d
commit d730798
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/ouster_client/src/client.cpp b/ouster_client/src/client.cpp
@@ -413,8 +413,8 @@ bool init_logger(const std::string& log_level, const std::string& log_file_path,
 
 std::shared_ptr<client> init_client(const std::string& hostname, int lidar_port,
                                     int imu_port) {
-    logger().info("initializing sensor: {} with ports: {}/{}", hostname,
-                  lidar_port, imu_port);
+    logger().info("initializing sensor: {} with lidar port/imu port: {}/{}",
+                  hostname, lidar_port, imu_port);
 
     auto cli = std::make_shared<client>();
     cli->hostname = hostname;

diff --git a/ouster_client/src/types.cpp b/ouster_client/src/types.cpp
@@ -783,7 +783,8 @@ static data_format parse_data_format(const Json::Value& root) {
     if (root.isMember("fps")) {
         format.fps = root["fps"].asInt();
     } else {
-        logger().warn("No fps found. Trying to use one from lidar mode (or 0)");
+        // logger().warn("No fps found. Trying to use one from lidar mode (or
+        // 0)");
         format.fps = 0;
     }
 

diff --git a/python/src/ouster/sdk/simple_viz.py b/python/src/ouster/sdk/simple_viz.py
@@ -24,11 +24,12 @@ def main() -> None:
     group.add_argument('--sensor', metavar='HOST', help='sensor hostname')
     group.add_argument('--pcap', metavar='PATH', help='path to pcap file')
     parser.add_argument('--meta', metavar='PATH', help='path to metadata json')
-    parser.add_argument('--lidar-port', type=int, help='lidar port for sensor')
+    parser.add_argument('--lidar-port', type=int,
+            help='configure sensor to use specified port for lidar data if running against sensor')
     parser.add_argument('-x',
                         '--no-auto-dest',
                         action='store_true',
-                        help='do not auto configure udp destination')
+                        help='do not auto configure udp destination if running against sensor')
     parser.add_argument('--extrinsics',
                         metavar="F",
                         type=float,