Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

08: Check for empty/malformed chapters, authors #79

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

hlieberman
Copy link
Contributor

This check replaces what is currently known as steps G (invalid author names), I (invalid author email addresses), and J (empty chapters). Note, it does not confirm that email addresses are in any way valid, or even properly formatted; merely that the import of whatever is in the column won't break the archive.

This check replaces what is currently known as steps G (invalid author
names), I (invalid author email addresses), and J (empty chapters).
Note, it does not confirm that email addresses are in any way valid, or
even properly formatted; merely that the import of whatever is in the
column won't break the archive.
Copy link
Collaborator

@ariana-paris ariana-paris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if in future, we might want to have all the checks run in one go and produce a report that the operator can slog through to pick off issues in random order, rather than stalling them on one issue at a time in a fixed order. They could also do with some automated testing to make sure nobody breaks them in future. But this is already so much better than relying on manual checks! 🏅

@ariana-paris ariana-paris merged commit dd5b73c into otwcode:master Mar 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants