OD-1730: Use Ruff for linting and formatting #74
Conversation
This also grandfathers in the current errors.
ariana-paris
changed the title
There was a problem hiding this comment.
Thank goodness for the Hide whitespace option 😆
I've approved but not merged as I made a couple of comments but nothing blocking, so it's just in case you want to review them. I suspect the massive SQL blocks we have in places will look wonky with the new indentation but that can be addressed if it bothers whoever works on those files in future. On the whole, the changes make sense and tidy things up nicely!
| ) | ||
|
|
||
| # Database settings | ||
| parser.add_argument( |
There was a problem hiding this comment.
Aw, RIP my "clever" manual table format 😆 (but I don't imagine many people use this as a reference for the parameters anymore now we use a config file instead)
shared_python/FinalTables.py
Outdated
|
|
||
| def _value(self, row): | ||
| value = [] | ||
| for item in row: | ||
| if type(item) is str: | ||
| if type(item) is str: # noqa: E721 |
There was a problem hiding this comment.
Would isinstance() work here?
There was a problem hiding this comment.
Yup! That's actually the right fix; I just didn't want to mix whitespace only changes with substantive ones in this patch, since it's hard enough to understand already. I'll make another PR to fix this one and the other isinstance underneath.
|
|
||
| tag_columns = ( | ||
| tag_col_lookup.keys() | ||
| ) # [d['col'] for d in tag_col_lookup if 'col' in d] |
There was a problem hiding this comment.
Not formatting related. Just noting the presence of some commented out code here in case anyone wants to remove it
shared_python/Tags.py
Outdated
| for val in re.split(r", ?", story_tags_row[col]): | ||
| if val != "": | ||
| if ( | ||
| type(tag_col_lookup[col]) is str # noqa: E721 |
There was a problem hiding this comment.
Same musing about isinstance as previously
git diff -w is highly recommended for this patch; the only substantive change is in the .github directory, adding the CI check for formatting correctness. The rest is the initial restyling.
Specifically, this targets E701 (if head and body on same line, fixed already by ruff format), E721 (not using isinstance).
Note: this is blocked by and includes #73. It should not be merged until after that has; setting to WIP to block it for now.