Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve audio connection stability #382

Merged
merged 3 commits into from
Dec 26, 2020

Conversation

vrnagy
Copy link
Contributor

@vrnagy vrnagy commented Dec 14, 2020

This change improves the connection handling of audio and adds extra info abot the current connection status to the player.
Along with #149 our connection issues went away. Every people can hear the others and no reconnection issues after every game

  • Fix WebRTC connection handling.
  • Add extra info about connection state for players.
  • Handle basic WebRTC errors.

Add extra info about connection state for players.
Handle basic WebRTC errors.
@MattJustMatt
Copy link

Seeing a teal circle on some player (person isn't present in audioConnected array?). It's not clear to a user what this would mean IMHO outside of reading the code.

@MattJustMatt
Copy link

(and tbh even from reading the code I'm still not sure what to do to fix!)

@vrnagy
Copy link
Contributor Author

vrnagy commented Dec 15, 2020

It meens that there is a problem with the WebRTC connection between the Player and You, but You're right, we shoild give some description what it means

@Soitora
Copy link

Soitora commented Dec 15, 2020

Would this fix some users not being able to hear others? Or does this need #149 merged as well?

@tystuyfzand
Copy link

It meens that there is a problem with the WebRTC connection between the Player and You, but You're right, we shoild give some description what it means

So, a warning? The universal status color for that is yellow, which may say "your connection isn't active" better than teal.

@vrnagy
Copy link
Contributor Author

vrnagy commented Dec 15, 2020

@Soitora it resolves the issue at the game end when everyone reconnects to each other. To fix the hearing problem it needs #149 as wel.

@tystuyfzand replaced the color to yellow

src/renderer/Voice.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants