Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAC sponsor should be sandbox stage requirement for WGs #262

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

marcelamelara
Copy link
Contributor

The current WG lifecycle process docs don't currently require a TAC sponsor until after the sandbox stage has been reached, even though the intent is for WGs the have TAC sponsor before applying for sandbox status. This PR adjusts the WG lifecycle process to reflect that having a TAC sponsor should be a requirement for WGs when applying for the sandbox stage.

@marcelamelara marcelamelara requested a review from a team as a code owner February 13, 2024 18:12
@lehors
Copy link
Contributor

lehors commented Feb 13, 2024

I'm not necessarily against this but what is the basis for your claim that "the intent is for WGs to have TAC sponsor before applying for sandbox status"?

@marcelamelara
Copy link
Contributor Author

I should have clarified this in the PR description. I posed an initial question about why the TAC sponsor (as currently documented) doesn't seem to be required for WGs before the incubating stage, even though I was under the impression that TAC sponsors were required sooner. A couple of folks replied that the intent apparently was to have a TAC sponsor be a requirement from the start, although the docs don't currently reflect this.

If this is open for debate, we can close this PR and open up an issue first.

CC @SecurityCRob and @steiza who had chimed in on Slack as well.

Copy link
Contributor

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this actually appears to match what we did for the AI/ML WG, which was proposed and eventually approved with a sponsor last year. Based on that I'm in favor of this change.
Thanks!

@marcelamelara
Copy link
Contributor Author

marcelamelara commented Feb 14, 2024

Talking to some project leads, it looks like a TAC sponsor was also needed to accept recent projects like protobom and SBOMit as a sandbox project (within the Security Tooling WG) though the project lifecycle docs don't reflect this. So I'll be pushing some updates to align with our current process.

EDIT: It looks like the ambiguity largely stems from what's documented in the TI Gives and Gets vs the actual lifecycle docs. We may at some point want to refactor these documents to reduce redundancies and/or resolve discrepancies.

@@ -44,7 +44,7 @@ The OpenSSF Sandbox is the entry point for early stage Projects and has four goa
* Provides project updates to OpenSSF Marketing Committee as requested.

#### Project Support
* Receives guidance on technical direction from TAC.
* Receives a TAC and WG sponsor for guidance on technical direction.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit different than what we defined for SIGs, which are similar to Projects in that they can report directly to the TAC or to a WG.

You can see the details of that discussion on #182, but where we landed was to define near the top of https://github.com/ossf/tac/blob/main/process/sig-lifecycle.md:

SIGs may report to a WG or directly to the TAC as their governing body.

... and then after that refer to their governing body instead of WG or TAC.

There's definitely a balance here. On one hand, we don't want a TAC vote for everything or we risk the TAC being a bottleneck for the organization to get anything done. On the other hand, the way the process is currently set up, any change in lifecycle involves a pull request in the TAC repo, and it is nice to be at least informed of changes taking place across the org.

I would be in favor of WGs adopting Projects at the Sandbox stage without requiring TAC approval, but I'm open to further discussion!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes! You found this discrepancy yourself - see also the discussion on #263 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My initial reason for spelling it out like this is that several recent projects like SBOMit and protobom have sought out a TAC sponsor to become sandbox. I totally agree that we shouldn't necessarily require TAC approval for every single TI either, so as you say, there's a balance to be struck. But the current TI Gives and Gets seems to make this a requirement for all TIs. So, some docs need to be adjusted, I'm just not sure where we want to draw the line.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the TI Gives + Gets is the odd one out here, so how about we do something like:

Change https://github.com/ossf/tac/blob/main/process/TI-Gives%2BGets.md?plain=1#L17:

* TI must find an aligned WG to host the TI or must have a TAC sponsor that can help guide the TI through processes.

Could also consider and/or.

We could also consider changing https://github.com/ossf/tac/blob/main/process/TI-Gives%2BGets.md?plain=1#L27C2-L27C64:

* TI receives guidance on technical direction if they have a TAC sponsor

I did a quick look at https://github.com/ossf/tac/tree/main/process/templates to ensure the Project and SIG templates don't explicitly require a TAC sponsor, so I think we're good there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these suggestions! What I like is that these will actually lower the barrier to entry for sandbox Projects and SIGs a little bit, so I'm definitely happy to adjust the TI Gives + Gets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we reconcile the need for opening a PR in this repo to submit a project's or SIG's sandbox application (which effectively amounts to a TAC approval) with the desire to make the TAC approval optional for projects and SIGs? Is this really about online vs offline TAC votes? This is something we ought to clarify in the docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving this discussion over to #268 .

@SecurityCRob SecurityCRob merged commit 6ef32bb into ossf:main Feb 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants