feat: global refacto #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request look good but please can you split the work in different commits ? |
|
@pythonbrad i made this in a live coding 🥲 ... you were present... i will try to split it... but i think it's more like a global refacto than an update(as a proposition) it coul be alo interesting to just pick some stuff from there to add on the main branch, as you can see i added the "DO NOT MERGE" tag |
This was referenced Sep 14, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
PS: there is still a lot to be done here in term of "tests" and documentation, but the script is working :
And a generated report can be available in a json file :
