Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging useStepTime -> into App.js #59

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Merging useStepTime -> into App.js #59

merged 3 commits into from
Dec 11, 2024

Conversation

JackMcPhillips1543
Copy link
Collaborator

Closes #50

What was changed:

  • useStepTime.js was removed
  • App.js was updated to take on all the functions of useStepTIme.js
  • Changed the unit tests in App.test.js

Why was it changed:

  • useStepTime.js opened an extra websocket that was unnecessary
  • The path the step time data had to take was unnecessary
  • Tests needed to be altered to fit new app.js

How was it changed:

  • All of the functions in useStepTime were brought over to App.js
  • Tests were altered by fixing how the rendering process works

Copy link
Collaborator

@git-voo git-voo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this!
Just note that we may have to review the threshold at which different borders are rendered. especially the yellow border. The question is, how close is close enough?

@colinseper colinseper removed their request for review November 28, 2024 21:04
@git-voo git-voo merged commit fbb1ea8 into main Dec 11, 2024
4 checks passed
@git-voo git-voo deleted the bug/appConsolidate branch December 11, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Condense useStepTIme.js with App.js
2 participants