Make Pnpm separate from Npm
#9274
Conversation
fviernau
force-pushed
the
pnpm-rewrite
branch
from
9e82e41
to
24a0b9f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| val declaredLicenses = packageJson.licenses.mapNpmLicenses() | ||
| val authors = parseNpmAuthor(packageJson.authors.firstOrNull()) // TODO: parse all authors. | ||
|
|
||
| var description = packageJson.description.orEmpty() |
Check warning
Code scanning / detekt
Var declaration could be val. Warning
| val authors = parseNpmAuthor(packageJson.authors.firstOrNull()) // TODO: parse all authors. | ||
|
|
||
| var description = packageJson.description.orEmpty() | ||
| var homepageUrl = packageJson.homepage.orEmpty() |
Check warning
Code scanning / detekt
Var declaration could be val. Warning
| expandNpmShortcutUrl(fromVersion).takeIf { it != fromVersion }.orEmpty() | ||
| } | ||
|
|
||
| var hash = Hash.create(packageJson.integrity.orEmpty()) |
Check warning
Code scanning / detekt
Var declaration could be val. Warning
| val declaredLicenses = packageJson.licenses.mapNpmLicenses() | ||
| val authors = parseNpmAuthor(packageJson.authors.firstOrNull()) // TODO: parse all authors. | ||
|
|
||
| var description = packageJson.description.orEmpty() |
Check warning
Code scanning / QDJVMC
Local 'var' is never modified and can be declared as 'val' Warning
| val authors = parseNpmAuthor(packageJson.authors.firstOrNull()) // TODO: parse all authors. | ||
|
|
||
| var description = packageJson.description.orEmpty() | ||
| var homepageUrl = packageJson.homepage.orEmpty() |
Check warning
Code scanning / QDJVMC
Local 'var' is never modified and can be declared as 'val' Warning
| expandNpmShortcutUrl(fromVersion).takeIf { it != fromVersion }.orEmpty() | ||
| } | ||
|
|
||
| var hash = Hash.create(packageJson.integrity.orEmpty()) |
Check warning
Code scanning / QDJVMC
Local 'var' is never modified and can be declared as 'val' Warning
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9274 +/- ##
============================================
- Coverage 67.67% 66.61% -1.06%
Complexity 1187 1187
============================================
Files 239 242 +3
Lines 7796 7923 +127
Branches 900 916 +16
============================================
+ Hits 5276 5278 +2
- Misses 2153 2278 +125
Partials 367 367
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fviernau
force-pushed
the
pnpm-rewrite
branch
from
24a0b9f
to
ed8f31d
Compare
fviernau
force-pushed
the
pnpm-rewrite
branch
from
ed8f31d
to
52f506a
Compare
Signed-off-by: Frank Viernau <[email protected]>
Prepare for re-use in an upcoming change. Signed-off-by: Frank Viernau <[email protected]>
Prepare for adding further `Pnpm` specific classes. Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
pnpm-rewrite
branch
4 times, most recently
from
6ca5623
to
5e3706e
Compare
Stop inheriting from `Npm` and rely entirely on the output of `pnpm` commands to figure out the necessary information. For example, do not re-construct the dependency from the file structure within `node_modles`, but rely on `pnpm list` instead. This tremendously reduces complexity and makes the implementation easy to understand and maintain. Apart from that it corrects issues with the dependency tree, such as: 1. htmlparser2 now dependends on domutils 1.7.0 instead of 1.5.1, which is inline with the dependency tree output by `pnpm list --depth 1000` 2. The cyclic reference from the workspace root project to itself is now included. Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
pnpm-rewrite
branch
from
5e3706e
to
f29ee32
Compare
Part of #9261.