Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gz-jetty: new formula #2942

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

azeey
Copy link
Member

@azeey azeey commented Jan 17, 2025

@azeey azeey requested a review from scpeters as a code owner January 17, 2025 02:01
Copy link
Collaborator

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some Ionic references that we probably need to update

@@ -0,0 +1,42 @@
class GzIonic < Formula
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class GzIonic < Formula
class GzJetty < Formula

include Language::Python::Virtualenv

desc "Collection of gazebo simulation software"
homepage "https://github.com/gazebosim/gz-ionic"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
homepage "https://github.com/gazebosim/gz-ionic"
homepage "https://github.com/gazebosim/gz-jetty"

version "0.999.999-0-20250116"
license "Apache-2.0"

head "https://github.com/gazebosim/gz-ionic.git", branch: "main"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
head "https://github.com/gazebosim/gz-ionic.git", branch: "main"
head "https://github.com/gazebosim/gz-jetty.git", branch: "main"

end

test do
assert_predicate share/"gz/gz-ionic/release_notes.md", :exist?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assert_predicate share/"gz/gz-ionic/release_notes.md", :exist?
assert_predicate share/"gz/gz-jetty/release_notes.md", :exist?

@azeey
Copy link
Member Author

azeey commented Jan 17, 2025

Fixed in 0202924

Also updated the bump_dependency.bash script
gazebo-tooling/release-tools#1239

@scpeters scpeters changed the title Bumps in jetty : ci_matching_branch/bump_jetty_gz-jetty gz-jetty: new formula Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants