Add Grenoble bike parking integration #2277
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frodrigo
reviewed
Jul 29, 2024
Comment on lines
+38
to
+39
| "https://www.data.gouv.fr/fr/datasets/parcs-de-stationnement-velos-de-la-metropole-de-lyon/", | ||
| "Localisation des stationnements vélos connus sur le territoire de la Métropole de Lyon", |
frodrigo
reviewed
Jul 29, 2024
Comment on lines
+31
to
+36
| self.def_class_missing_official(item = 8150, id = 1, level = 3, tags = ['merge', 'public equipment', 'bicycle', 'fix:survey', 'fix:picture'], | ||
| title = T_('Bicycle parking not integrated')) | ||
| self.def_class_possible_merge(item = 8151, id = 3, level = 3, tags = ['merge', 'public equipment', 'bicycle', 'fix:survey', 'fix:picture'], | ||
| title = T_('Bicycle parking integration suggestion')) | ||
| self.def_class_update_official(item = 8152, id = 4, level = 3, tags = ['merge', 'public equipment', 'bicycle', 'fix:survey', 'fix:picture'], | ||
| title = T_('Bicycle parking update')) |
There was a problem hiding this comment.
Ids should be not already used ids.
|
@XioNoX still interested in this PR ? |
Yep, waiting for some news on https://forum.openstreetmap.fr/t/la-communaute-dagglo-niort-agglo-vient-de-publier-les-emplacements-des-parkings-a-velos/10765/15 to fine-tune it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://forum.openstreetmap.fr/t/la-communaute-dagglo-niort-agglo-vient-de-publier-les-emplacements-des-parkings-a-velos/10765/10
Tested locally and works fine, but most likely some fine tuning to do before merging.
"mob_arce_typ": "arceaux moto""mob_arce_datecre"(eg. 19900101000000 seems incorrect).stands?ref:FR:GrenobleAlpesMetropole"correct/needed ?"operator": "Grenoble-Alpes Métropole"correct ?