Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon.ico to apache default vhost #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

psampont
Copy link
Contributor

Autre petite amélioration, voici un P.R. pour le problème #7

@psampont psampont changed the title Add favicon.ico to apache default vhost #7 Add favicon.ico to apache default vhost Jan 12, 2019
@jocelynj
Copy link
Member

C'est pas mal, effectivement.

Le seul souci, c'est que ce code ne sera appelé que si install_apache=True, qui n'est actuellement setté que tu osm154. Il faudrait du coup qu'on rajoute install_apache sur toutes les machines qui ont apache avant de pouvoir rajouter le favicon via ta modif.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants