Fixes #167, NormalizationParameter defaults introduced in #161
#168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* optional arguments In #161 some additional parameters were added to `NormalizationParameters`. This caused trouble in `NormalizerGSF`, which assumed that all parameters/attributes in `NormalizationParameters` have to be set. * Sphinx docs: Workaround for documentation of non default members.
|
On the optional arguments: For now, I added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optional arguments
In Convenience functions for Matrix, Vector and NormalizationParameters #161 some additional parameters were added to
NormalizationParameters. This caused trouble inNormalizerGSF, whichassumed that all parameters/attributes in
NormalizationParametershave to be set.
Sphinx docs:
Workaround for documentation of non default members.
Necessary due to Support for typing and dataclass fields astropy/sphinx-automodapi#115