Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates/packer: configure pulp creds on startup #3780

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

kingsleyzissou
Copy link
Contributor

Configure pulp credentials on worker startup.

@kingsleyzissou kingsleyzissou added WIP+test Work in progress but run Gitlab CI. and removed WIP+test Work in progress but run Gitlab CI. labels Nov 2, 2023
@kingsleyzissou kingsleyzissou marked this pull request as ready for review November 2, 2023 18:15
@yih-redhat
Copy link
Contributor

hi, with this pr, do we need to change/update test cases in https://github.com/osbuild/osbuild-composer/blob/main/test/cases/ostree-pulp.sh ?
And one more question, I can see the pulp server, username and password in this pr, so there will be an embedded pulp server here? because from my understanding, customer is supposed to setup their own pulp server environment.

@kingsleyzissou
Copy link
Contributor Author

hi, with this pr, do we need to change/update test cases in https://github.com/osbuild/osbuild-composer/blob/main/test/cases/ostree-pulp.sh ? And one more question, I can see the pulp server, username and password in this pr, so there will be an embedded pulp server here? because from my understanding, customer is supposed to setup their own pulp server environment.

This PR is so we can eventually use pulp in the service, at the moment there is a pulp instance in staging. This kind of goes together with the #3744 pr. As for users who want to use this on-prem, they will have to configure a pulp server themselves.

Regarding the test, I'm not sure if we run any tests against stage, maybe @croissanne can correct me?

Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!!

@croissanne croissanne merged commit 3fe36d0 into osbuild:main Nov 7, 2023
72 checks passed
@kingsleyzissou kingsleyzissou deleted the pulp-creds branch May 2, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants