Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: Fix implicit memory aliasing in for loops #3687

Closed
wants to merge 1 commit into from
Closed

lint: Fix implicit memory aliasing in for loops #3687

wants to merge 1 commit into from

Conversation

bcl
Copy link
Contributor

@bcl bcl commented Sep 15, 2023

Fix all instances of gosec G601: Implicit memory aliasing in for loop.

This pull request includes:

  • adequate testing for the new functionality or fixed issue
  • adequate documentation informing people about the change such as

@bcl
Copy link
Contributor Author

bcl commented Sep 15, 2023

Also included this in latest update to PR #3683

@achilleas-k
Copy link
Member

Should we close this in favour of #3683?

@bcl
Copy link
Contributor Author

bcl commented Sep 18, 2023

Should we close this in favour of #3683?

If CI will ever pass, yes :)

thozza
thozza approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@henrywang
Copy link
Member

Tests / edge-commit-cs9 has been fixed by PR #3684. This failure can be skipped.

@bcl @achilleas-k
lint: Fix implicit memory aliasing in for loops
8ab3d12 
Fix all instances of gosec G601: Implicit memory aliasing in for loop.
@achilleas-k
Copy link
Member

Closing this for #3683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thozza thozza thozza approved these changes

@achilleas-k achilleas-k achilleas-k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bcl @achilleas-k @henrywang @thozza