Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oci object storage target #3675

Merged
merged 5 commits into from
Sep 19, 2023
Merged

oci object storage target #3675

merged 5 commits into from
Sep 19, 2023

Conversation

croissanne
Copy link
Member

No description provided.

@croissanne croissanne force-pushed the ociostarget branch 8 times, most recently from 914230f to ce2f3e5 Compare September 8, 2023 12:25
@croissanne croissanne marked this pull request as ready for review September 8, 2023 13:36
@croissanne croissanne force-pushed the ociostarget branch 12 times, most recently from 76b3d16 to 8b58e37 Compare September 13, 2023 11:47
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD 8b58e37 with the main merge-base e698e10). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/5077265830/artifacts/browse

cmd/osbuild-upload-oci/main.go Outdated Show resolved Hide resolved
cmd/osbuild-worker/jobimpl-osbuild.go Outdated Show resolved Hide resolved
cmd/osbuild-worker/jobimpl-osbuild.go Outdated Show resolved Hide resolved
cmd/osbuild-worker/jobimpl-osbuild.go Outdated Show resolved Hide resolved
@kingsleyzissou
Copy link
Contributor

Neat, just a few inline comments :)

@croissanne croissanne force-pushed the ociostarget branch 4 times, most recently from ab76ee9 to 52855a0 Compare September 15, 2023 13:05
kingsleyzissou
kingsleyzissou previously approved these changes Sep 15, 2023
Copy link
Contributor

@kingsleyzissou kingsleyzissou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Uploads an OCI image to OCI object storage, and generates a
pre-authenticated request for the object, which can be used to import it
into custom images.
Useful for hosted deployments, where target options are often empty or
incomplete.
@croissanne croissanne merged commit 1e7e130 into osbuild:main Sep 19, 2023
36 checks passed
@croissanne croissanne deleted the ociostarget branch September 19, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants