Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: switch to platform.machine #96

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

supakeen
Copy link
Member

For some reason on a bunch of my systems platform.processor() always returns an empty string. platform.machine() consistently works on those systems.

This closes #95.

For some reason on a bunch of my systems `platform.processor()` always
returns an empty string. `platform.machine()` consistently works on
those systems.

This closes osbuild#95.

Signed-off-by: Simon de Vlieger <[email protected]>
@supakeen supakeen requested review from ondrejbudai and mvo5 and removed request for ondrejbudai January 25, 2025 11:41
Copy link
Collaborator

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, reading the doc strings for both "machine()" seems the (much more) correct helper here.

@supakeen supakeen added this pull request to the merge queue Jan 27, 2025
Merged via the queue into osbuild:main with commit cfe8f7c Jan 27, 2025
27 of 28 checks passed
@supakeen supakeen deleted the platform-machine branch January 27, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest integration tests fail on my machine
2 participants