Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image-builder: drop internal manifestgen in favor of images #92

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

mvo5
Copy link
Collaborator

@mvo5 mvo5 commented Jan 24, 2025

This commit drops the internal manifestgen package in favor
of using the version in images now that
osbuild/images#1153 is merged.

Copy link
Member

@supakeen supakeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests currently broken, added a suggestion that might fix it.

cmd/image-builder/manifest.go Show resolved Hide resolved
This commit drops the internal `manifestgen` package in favor
of using the version in `images` now that
osbuild/images#1153 is merged.
@mvo5 mvo5 force-pushed the use-images-manifestgen branch from d2d9c31 to 21eba2c Compare January 27, 2025 09:25
@supakeen supakeen added this pull request to the merge queue Jan 27, 2025
Merged via the queue into osbuild:main with commit 98e4beb Jan 27, 2025
4 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants