Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VFS Archive support #67

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ajmeese7
Copy link
Member

Meant to close out #64, pending the merge of os-js/osjs-gui#40 and os-js/osjs-filemanager-application#41. Will result in the resolution of os-js/osjs-filemanager-application#39 as well.

Opening as a draft because there are still a few slight modifications that I want to make, most notably a try/catch for the compress action that deletes the ZIP file on an error rather than leaving behind a corrupt artifact. Also there is one test (noted with a TODO) that I implemented that still doesn't work and that I have been unable to figure out, so some help with that would be appreciated.

@ajmeese7
Copy link
Member Author

Also yes, as the CI pointed out, I didn't update the lockfile yet either.

@ajmeese7
Copy link
Member Author

I don't know why the CI linter doesn't like my switch statement but I don't see anything wrong with it, the indentation looks correct to me. @andersevenrud could you weigh in when you get a chance?

I could change the eslint rules to the following if you want, this should solve it: indent: ['error', 2, { SwitchCase: 1 }],

@andersevenrud
Copy link
Member

I could change the eslint rules to the following if you want, this should solve it

Feel free to do so. I don't think I have a switch statement in the codebase anywhere else, so this has never popped up for me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants