Add support for b64flt, b64byt and b64srt #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses discussion in Issue ornl-epics#21 to support different array types.
This was referenced May 10, 2024
kasemir
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #21 currently only b64int and b64dbl arrays are supported. I have added support for float arrays, short arrays and byte arrays in PVWS sent as b64flt, b64srt and b64byt.
In addition, PVWS was automatically handling all byte arrays as strings meaning that clients did not receive the original char array. I have updated PVWS to handle these as byte arrays and send as such. It is then up to the client to format this as a string if that format option is set.