feature: external url control with regular links

[dahlalex]

Aims to fix #2064
Linked with #330

[johnnyblasta]

Tested and LGTM

[dahlalex]

I wonder how can I control the display order of external links Conttrol on the map?

I've specified the desired order (which is first) in index.json file, but the external links control is still rendering in a different order. Is there a way to ensure that the control I've placed first in the index.json file is also displayed first on the map?

[steff-o]

In general the controls should be added in the configured order but there are some controls that are "default" and are added before the "non-default".

The default controls are (from origo.js):

 defaultControls: [
   { name: 'localization' },
   { name: 'scaleline' },
   { name: 'zoom' },
   { name: 'rotate' },
   { name: 'attribution' },
   { name: 'fullscreen' }
 ]

Not all of them are in the left toolbar so they don't matter but I can't find any explanation to why home control comes before externalurl.

[dahlalex]

Thank you for your explanation.

I've consulted with a colleague, and it appears that the order of the home and externalurl controls is determined by their categorization.

Specifically, home is classified as a navigation control, while externalurl is considered a map tool.

According to the origo/src/components/main.js, navigation controls are rendered before map tools, which explains the observed order.

it seems that controlling the specific order of these controls is beyond the scope of this particular pull request.
This could be an interesting topic to explore in future discussions.

[steff-o]

Alrighty! I missed that subtle part where controls either calls getMain().getNavigation() or getMain().getMapTools() or the other ones to get their parent element.