Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lib.ts to support exports that start with $ and _ #51

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nicksrandall
Copy link

This will detect exports that start with $ and _.

Here is a snippet from @lexical/html that was causing an issue for me:

exports.$generateHtmlFromNodes = $generateHtmlFromNodes;
exports.$generateNodesFromDOM = $generateNodesFromDOM;

The updated regex will correctly identify this module as common-js.

@nicksrandall
Copy link
Author

Anything I can do to help this get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant