Skip to content

Commit

Permalink
fix: addresses edge-case where perform-tasks fails when pushing large…
Browse files Browse the repository at this point in the history
… template to 2+ regions (#570)

region is not being passed as an argument to
GetCredentialProviderWithRoleAssumptions when building the cacheKey.
This results in a cached S3Client being returned when a new one should
be built for the 2nd region

Co-authored-by: Joe Grgic <[email protected]>
  • Loading branch information
kuggis and Joe Grgic authored Aug 8, 2024
1 parent 91f02e8 commit d503e03
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/util/aws-util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,7 @@ export class AwsUtil {
AwsUtil.throwIfNowInitiazized();
const { cacheKey, provider } = AwsUtil.GetCredentialProviderWithRoleAssumptions({
accountId,
region,
roleInTargetAccount,
});
const config: S3ClientConfig = {
Expand Down

0 comments on commit d503e03

Please sign in to comment.