Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method labels in Tabs #2935

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kalexhaym
Copy link
Contributor

Fixes #

Proposed Changes

  • add new feature in tabs
  • new method "labels" that allows you to set custom tab names
  • this may be necessary when you need to make several tabs on one page with the same labels but with different keys

@tabuna
Copy link
Member

tabuna commented Jan 26, 2025

Hi! Sorry for the delay. 😊 I'm a bit confused—how would renaming help us properly switch between tabs with the same name?

Switching happens based on the id, not the name. To fix this, we could add a prefix in the template, for example:

<a data-bs-target="#tab-{{ \Illuminate\Support\Str::slug($templateSlug . $name) }}">

What do you think? 😊

tabuna added a commit that referenced this pull request Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants