-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lua extension #414
Lua extension #414
Conversation
- fixed oapi.readitem_string() - added oapi.formatvalue()
=> disabled for now
CI Tests seem to fail 😞 |
- os.remove() disabled
- all writes disabled
- further tests disabled
- not much testing left :(
I am out of ideas 😞 |
- another wild guess: Scenario maybe?
Does it give any error report if you run the "test" from a command console ? which might be: |
Do I have to be in a Visual-Studio console? |
Result:
|
- removed MFD_(Left|Right) completely from Scenario.
I got it to run some tests with: |
Looks like the problem is somewhere in: |
I think it might have to do with "what CMake" we are using. The one included in Visual Studio might not be 100% compatible...
Yes, that's easy to see, but why Timeout? The current Test is almost empty now and can only succeed! It would be enough (I think) if I could get the |
This is what I would expect (run locally in a "normal" cmd):
For reference (Tests/VesselApiTest):
|
Ok, so, you have written that GeneralAPITest. Then you probably know much more about the tests than I do. |
- added time-acceleration to Lua-Script, similar to VesselApiTest.lua (desperate I am)
I am tending to believe, that the "Test suite" was never able to run more than one Lua-based test... Can we invite someone with knowledge about this? Tomorrow I will likely commit an exact 1 to 1 copy of the working VesselApiTest, just renamed to GenericApiTest, to see what will happen. |
Sure, Of course, why would that be a problem. |
...not a general problem 😉 just one that is caused by: I don't know "someone" 😁 |
That would be @DarkWanderer |
…icApiTest, to see what will happens.
@jarmonik : Do you have a orbiter-forum name of @DarkWanderer ? |
Yes, I got the notification. Am I correct in assuming the issue is that 2 or more tests cannot be executed in parallel? If yes, I can take a look later - it is probably something about Orbiter not being able to run 2 instances at same time |
Wow! commit d60513c did let the test(s) pass 😮 ... |
That was just my uneducated guess 😊 ...I just found out, that that is not the general case. Here are my questions to you:
|
- oapi.get_orbiter_version() - oapi.rand() - oapi.deflate() - oapi.inflate() - oapi.formatvalue()
- oapi.openfile() with "write-first" to have a known file in root.
O.K. here we fail again! |
Aaaaargh! This trial & error thing drives me nuts! It seems it's not (only) the file-i/o. |
…tem_xxx() tests re-activated.
Phew! That was ugly. Final results
|
PR to resolve #404 &
to resolve #405.
This PR has currently only one unresolved issue:
The automatic (headless) tests currently can not run MFD tests.
Still I like to have at least some kind of Test, therefore I've added that Test-Scanario in a sub-folder
.\Scenarios\Tests\Manual\
which should not be run automatically (I think).An alternative might be to change the according
file(GLOB ...)
section in.\Tests\CMakeLists.txt
to exclude some "special names".I am not an expert in CMake setups, so I didn't took that approach.
Changes:
added following file i/o functions to Lua interface:
added following utility functions to Lua interface:
added Lua tests for generic API functions
added Lua test for ScriptMFD (manual test)