Fix Option Save #403
Merged
Fix Option Save #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le/disable sub-options
|
Probably wouldn't hurt to, pull, rebase, and compile just to make sure. But
yeah it's probably fine.
…On Fri, Jan 5, 2024, 21:15 GLS-SSV ***@***.***> wrote:
Options in Visual settings and Physics settings pages were not being
immediately saved, which caused any changes to be lost when changing to
another options page. This PR should fix that issue, and also adds logic to
disable the Planet night light level text box when Planet night lights are
disabled, and also disable the terrain interpolation combo box when Surface
elevation is disabled.
BEWARE: I'm using VS2017 and cannot compile the latest version of the
code, so this was only tested in a 1 year+ old code version. I think it
should work fine and not need any further work but still, it should be well
tested in the latest code before merging.
------------------------------
You can view, comment on, or merge this pull request online at:
#403
Commit Summary
- 23a1ca5
<23a1ca5>
added missing logic to save option changes upon their change and
enable/disable sub-options
File Changes
(2 files <https://github.com/orbitersim/orbiter/pull/403/files>)
- *M* Src/Orbiter/OptionsPages.cpp
<https://github.com/orbitersim/orbiter/pull/403/files#diff-6ba3ce453df166a648c2fb8b4f613fca8e5ae9fa0f1a4ce24d320b0baf68f47b>
(217)
- *M* Src/Orbiter/OptionsPages.h
<https://github.com/orbitersim/orbiter/pull/403/files#diff-bca607538bc45de327453023fd3c0a4dd304506e279f1a54463ded8558eebd30>
(1)
Patch Links:
- https://github.com/orbitersim/orbiter/pull/403.patch
- https://github.com/orbitersim/orbiter/pull/403.diff
—
Reply to this email directly, view it on GitHub
<#403>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAYP32ENV5CAHG7TIZ66STYNCXSPAVCNFSM6AAAAABBPGRAZKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA3DQMRZGQZTQMA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
n7275
approved these changes
Jan 6, 2024
|
I rebased against upstream/Main and build on VS2022. No issues with the build, and the feature works as advertised. Approved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Options in Visual settings and Physics settings pages were not being immediately saved, which caused any changes to be lost when changing to another options page. This PR should fix that issue, and also adds logic to disable the Planet night light level text box when Planet night lights are disabled, and also disable the terrain interpolation combo box when Surface elevation is disabled.
BEWARE: I'm using VS2017 and cannot compile the latest version of the code, so this was only tested in a 1 year+ old code version. I think it should work fine and not need any further work but still, it should be well tested in the latest code before merging.