-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update new sdk #326
update new sdk #326
Conversation
WalkthroughThe changes involve version increments for two packages: Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Code Coverage Summary
Diff against main
Results for commit: 9d7d004 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
packages/contracts-build/data/oraiswap-v3.wasm
is excluded by!**/*.wasm
packages/oraiswap-v3/tests/data/oraiswap-v3.wasm
is excluded by!**/*.wasm
Files selected for processing (3)
- packages/contracts-build/package.json (1 hunks)
- packages/contracts-sdk/package.json (1 hunks)
- packages/contracts-sdk/src/OraiswapV3.types.ts (1 hunks)
Files skipped from review due to trivial changes (2)
- packages/contracts-build/package.json
- packages/contracts-sdk/package.json
Additional comments not posted (1)
packages/contracts-sdk/src/OraiswapV3.types.ts (1)
431-431
: Type definition updated for better specificity.The change from
number
toUint64
for the second element of the tuple inArrayOfTupleOfUint16AndUint64
enhances type specificity and safety. This is a positive change assuming that all usages of this type have been updated accordingly.The code changes are approved.
Run the following script to verify the usage of
ArrayOfTupleOfUint16AndUint64
across the codebase:
Summary by CodeRabbit
New Features
@oraichain/oraidex-contracts-build
package to 1.0.36.@oraichain/oraidex-contracts-sdk
package to 1.0.50.Improvements
OraiswapV3.types.ts
by modifying the tuple definition for better precision.