Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rejuvenate log levels #3617

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yiming-tang-cs
Copy link

Here's a reissue of #2978 which is closed due to inactivity and conflicts. We have run our logging tool on the last version of the project and solved all conflicts. We appreciate any feedback and are willing to make further changes if you wish to incorporate our PR into your project.

Settings

We have several analysis settings. We can vary these settings and rerun if you desire. The settings we are using in this pull request are:

  • Treat CONFIG, WARNING, and SEVERE levels as a category and not a traditional level, i.e., our tool ignores these log levels.
  • Never lower the logging level of logging statements within catch blocks.
  • Never lower the logging level of logging statements within if statements.
  • Never lower the logging level of logging statements containing certain (important) keywords.
  • Never raise the logging level of logging statements without particular keywords in their messages.
  • Avoid log wrapping by disregarding logging statements contained in if statements mentioning log levels.
  • Only consistently transform the level of logging statements appearing in overriding methods.
  • Adjust transformations if their transformation distances are over maximum transformation distance.

The greatest number of commits from HEAD evaluated: 5000.
The head at the time of analysis was: a31748b

OCA

I signed and emailed the OCA to Oracle. I am also providing a written acceptance of the OCA line:

I am signing on behalf of myself as an individual and no other person or entity, including my employer, has or will have rights with respect my contributions.

@ahornace
Copy link
Contributor

ahornace commented Jun 2, 2021

Cool! Are there any articles (thesis) publicly available which look at the tool in detail? I'd like to read more on that :)

@yiming-tang-cs
Copy link
Author

We have a research paper for this project: https://arxiv.org/pdf/2104.07736.pdf. Please feel free to contact us if you have any questions.

@vladak
Copy link
Member

vladak commented Jun 4, 2021

I think we should probably pick just some pieces, not the whole thing.

@khatchad
Copy link

khatchad commented Jun 4, 2021

If comment on the lines, @saledouble can revert those specific lines. If you can comment on why a particular transformation is undesirable, that would be very helpful. Thank you again for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants