Code sample - 23ai Vector Search with JDBC #353
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
| } | ||
|
|
||
| private void insertVectorWithVarChar2(Connection connection) throws SQLException { | ||
| PreparedStatement insertStatement = connection.prepareStatement(insertSql); |
There was a problem hiding this comment.
Please use try with resources in such methods as this code as-is leaks cursors (the statement isn't closed).
|
|
||
| public class OracleAIVectorSearchWithJava { | ||
|
|
||
| private final static String URL = "<JDBC_CONNECTION_URL>"; |
There was a problem hiding this comment.
Please use 2 space chars for padding.
|
@Kuassim @jeandelavarene adjustment performed as requested - fix the indentation + try-with-resources. |
| } | ||
|
|
||
| private int randomize() { | ||
| return ThreadLocalRandom.current().nextInt(); |
There was a problem hiding this comment.
Please define ID as
NUMBER GENERATED ALWAYS as IDENTITY(START with 1 INCREMENT by 1)
and avoid using a random number for your primary key.
There was a problem hiding this comment.
Done as requested - added NUMBER GENERATED ALWAYS as IDENTITY(START with 1 INCREMENT by 1),
modified the Java JDBC code, and removed the randomize() method. @Kuassim, please review; thanks.
Signed-off-by: Juarez Barbosa [email protected]
@Kuassim @jeandelavarene please review and approve. Thanks!