Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code sample - 23c JDBC Reactive Extensions #317

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

juarezjuniorgithub
Copy link
Member

Code sample - 23c JDBC Reactive Extensions
Signed-off-by: Juarez Barbosa [email protected]

private Flow.Publisher<Boolean> createTable(OracleConnection connection) throws SQLException {

OraclePreparedStatement createTableStatement = (OraclePreparedStatement) connection
.prepareStatement("CREATE TABLE employee_names (" + "id NUMBER PRIMARY KEY, "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the async APIs for a DDL wouldn't it be common. A better code sample should show a SELECT query and a DML.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, I don't disagree with you on that, but at the end of the day, the goal is to present the use of our async API and the extensions offering, and it can be used with any SQL statement (DDL, DQL, DML, DCL and TCL) as it will be issued in an async way regardless of the semantics of the SQL statement, so the purpose of it is not defeated at all.
I proposed to create part 2 of this blog post (which just wanted to serve as an intro as no blog post existed about such API) as a more complete segway and then explore CRUD scenarios in it, so I added it as a TODO item for me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 10, 2024
@juarezjuniorgithub
Copy link
Member Author

@Kuassim @jeandelavarene please review. Thanks!


<name>jdbc-reactive-extensions-intro</name>
<description>Introduction to JDBC Reactive Extensions with the Oracle
Database 23c Free — Developer Release</description>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change 23c to 23ai.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please remove " - Developer Release" as starting with 23.4, it no longer is a Developer Release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to make it release-agnostic as requested. @Kuassim please review. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants