Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4294 : Added Success Dialog for Profile Deletion with Updated Flow and Tests. #5575

Closed

Conversation

theayushyadav11
Copy link
Contributor

Description

This PR introduces a confirmation dialog that appears after a profile is successfully deleted. The DeleteProfileSuccessDialogFragment informs the user that the deletion was successful and then navigates to the appropriate activity based on the device configuration (either AdministratorControlsActivity for tablets or ProfileListActivity for non-tablet devices).

Key Components

  1. DeleteProfileSuccessDialogFragment

    • This dialog fragment displays a success message to the user.
    • Upon pressing "OK," it directs the user to either the AdministratorControlsActivity or ProfileListActivity, depending on whether the device is a tablet.
  2. Dependency Injection

    • DeleteProfileSuccessDialogFragment is added to the injection mechanism in FragmentComponentImpl, allowing the dialog to be used across different parts of the app.
  3. ProfileEditFragmentPresenter Update

    • The profile deletion flow is modified to invoke DeleteProfileSuccessDialogFragment after a profile is successfully deleted.
    • This modular approach improves user feedback and simplifies navigation by managing the post-deletion flow in one place.

Testing

Tests are updated to verify:

  • The appearance of the profile deletion success dialog.
  • Correct navigation occurs after profile deletion, tailored for tablet or non-tablet configurations.

Example Usage

The success dialog fragment is invoked automatically after a profile is deleted from the ProfileEditFragmentPresenter. Users will receive immediate feedback confirming the deletion, enhancing the app's user experience.
Also the talkback feature also works well.


Video Demo

TalkBackRecording.mp4

@theayushyadav11 theayushyadav11 deleted the delete-profile-message branch November 16, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants