Fix #5455: Resolve crash in AudioViewModel by initializing state variables #5561

TanishMoral11 · 2024-10-28T07:24:35Z

Explanation:

This PR addresses issue [BUG]: The app crashes occasionally when the device is rotated during exploration. #5455, which involves a crash caused by kotlin.UninitializedPropertyAccessException in AudioViewModel when the device is rotated during exploration.
The fix ensures proper initialization of state variables in the loadAudio() function, which prevents the app from crashing due to uninitialized properties.

Essential Checklist:

The PR title and explanation each start with "Fix [BUG]: The app crashes occasionally when the device is rotated during exploration. #5455: ".
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

github-actions · 2024-10-29T04:03:26Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 8684 bytes (Removed)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 3377 bytes (Removed)

Method count: 259758 (old), 259758 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6815 (old), 6815 (new), 0 (No change)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 967 (old), 967 (new), 0 (No change)
Dimen: 1048 (old), 1048 (new), 0 (No change)
Drawable: 379 (old), 379 (new), 0 (No change)
Id: 1275 (old), 1275 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 380 (old), 380 (new), 0 (No change)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 850 (old), 850 (new), 0 (No change)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 8684 bytes (Removed)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 3878 bytes (Removed)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 8692 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 2625 bytes (Removed)

Method count: 116054 (old), 116054 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5783 (old), 5783 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 341 (old), 341 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 8696 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 4631 bytes (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 9 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 8996 bytes (Removed)

Method count: 116060 (old), 116060 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5783 (old), 5783 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 341 (old), 341 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 10 MiB (new), 9 KiB (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 5428 bytes (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 9980 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 5290 bytes (Removed)

Method count: 116060 (old), 116060 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5783 (old), 5783 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 341 (old), 341 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 10 MiB (new), 9980 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 2771 bytes (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

adhiamboperes

Thanks @TanishMoral11!

I feel like this solution is not robust because it provides no explanation why the variable is not being initialized. It also does not provide an actual fallback. What should happen if the state and id are null?

adhiamboperes · 2024-10-28T13:38:43Z

app/src/main/java/org/oppia/android/app/player/audio/AudioViewModel.kt

@@ -88,6 +90,8 @@ class AudioViewModel @Inject constructor(
   * @param allowAutoPlay If false, audio is guaranteed not to be autoPlayed.
   */
  private fun loadAudio(contentId: String?, allowAutoPlay: Boolean, reloadingMainContent: Boolean) {
+    // Check if 'state' is initialized before proceeding.


This comment is not needed as the code is self explanatory

Thanks @adhiamboperes , I'll remove that comment to maintain a clean codebase.

adhiamboperes · 2024-10-29T06:15:40Z

app/src/main/java/org/oppia/android/app/player/audio/AudioViewModel.kt

+  fun setStateAndExplorationId(newState: State?, id: String?) {
+    if (newState != null && id != null) {
+      state = newState
+      explorationId = id
+    }


I have traced the usage of this function to:

oppia-android/app/src/main/java/org/oppia/android/app/player/state/StatePlayerRecyclerViewAssembler.kt

Lines 276 to 283 in f7e4651

if (playerFeatureSet.supportAudioVoiceovers) {

val processedStateName = ephemeralState.state.name

val audioManager = getAudioUiManager()

val activityId = checkNotNull(audioActivityId) {

"Expected the audio activity ID to be set when voiceovers are enabled"

}

audioManager?.setStateAndExplorationId(ephemeralState.state, activityId)

. Here, I can see that we perform a nullcheck for id, but not for state. As state is the variable throwing the uninitialized property exception, it might be worth finding a more indpeth reason why it is not being initialized on time. Or perharbs both values are not being initialized on time.

Hey @adhiamboperes,
Thanks for the insight! I will also ensure to add null checks for both state and id to prevent the issue.
I'll keep you updated on my progress!

github-actions · 2024-10-30T04:02:06Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 8984 bytes (Removed)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 4233 bytes (Removed)

Method count: 259758 (old), 259760 (new), 2 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6815 (old), 6815 (new), 0 (No change)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 967 (old), 967 (new), 0 (No change)
Dimen: 1048 (old), 1048 (new), 0 (No change)
Drawable: 379 (old), 379 (new), 0 (No change)
Id: 1275 (old), 1275 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 380 (old), 380 (new), 0 (No change)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 850 (old), 850 (new), 0 (No change)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 8984 bytes (Removed)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 5934 bytes (Removed)
Method count: 259758 (old), 259760 (new), 2 (Added)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 8580 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 2713 bytes (Removed)

Method count: 116054 (old), 116055 (new), 1 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5783 (old), 5783 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 341 (old), 341 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 8580 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 4653 bytes (Removed)
Method count: 116054 (old), 116055 (new), 1 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 9 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 5930 bytes (Removed)

Method count: 116060 (old), 116061 (new), 1 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5783 (old), 5783 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 341 (old), 341 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 10 MiB (new), 9 KiB (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 2832 bytes (Removed)
Method count: 116060 (old), 116061 (new), 1 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 9896 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 6109 bytes (Removed)

Method count: 116060 (old), 116061 (new), 1 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5783 (old), 5783 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 341 (old), 341 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 10 MiB (new), 9896 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 3211 bytes (Removed)
Method count: 116060 (old), 116061 (new), 1 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

TanishMoral11 · 2024-10-30T10:27:03Z

@adhiamboperes PTAL

oppiabot · 2024-10-30T10:30:07Z

Unassigning @TanishMoral11 since a re-review was requested. @TanishMoral11, please make sure you have addressed all review comments. Thanks!

TanishMoral11 · 2024-11-02T07:13:31Z

Hi @adhiamboperes , could you take a look at this PR ?
Let me know if there's anything more I should adjust.
Thanks!

github-actions · 2024-11-04T04:08:37Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 9667 bytes (Removed)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 3332 bytes (Removed)

Method count: 259758 (old), 259760 (new), 2 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6816 (old), 6815 (new), 1 (Removed)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 967 (old), 967 (new), 0 (No change)
Dimen: 1048 (old), 1048 (new), 0 (No change)
Drawable: 380 (old), 379 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1275 (old), 1275 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 380 (old), 380 (new), 0 (No change)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 850 (old), 850 (new), 0 (No change)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 9635 bytes (Removed)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 4955 bytes (Removed)
Method count: 259758 (old), 259760 (new), 2 (Added)
Resources: 6766 (old), 6765 (new), 1 (Removed)

Drawable: 335 (old), 334 (new), 1 (Removed)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 9111 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 2968 bytes (Removed)

Method count: 116054 (old), 116055 (new), 1 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5783 (new), 1 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 341 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 9071 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 4898 bytes (Removed)
Method count: 116054 (old), 116055 (new), 1 (Added)
Resources: 5741 (old), 5740 (new), 1 (Removed)

Drawable: 302 (old), 301 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 10 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 4218 bytes (Removed)

Method count: 116060 (old), 116061 (new), 1 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5783 (new), 1 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 341 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 10 MiB (new), 10 KiB (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 2078 bytes (Removed)
Method count: 116060 (old), 116061 (new), 1 (Added)
Resources: 5741 (old), 5740 (new), 1 (Removed)

Drawable: 302 (old), 301 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 10 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 7097 bytes (Removed)

Method count: 116060 (old), 116061 (new), 1 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5783 (new), 1 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 341 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 10 MiB (new), 10 KiB (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 2940 bytes (Removed)
Method count: 116060 (old), 116061 (new), 1 (Added)
Resources: 5741 (old), 5740 (new), 1 (Removed)

Drawable: 302 (old), 301 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

github-actions · 2024-11-05T04:00:19Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 9983 bytes (Removed)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 3462 bytes (Removed)

Method count: 259758 (old), 259760 (new), 2 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6816 (old), 6815 (new), 1 (Removed)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 967 (old), 967 (new), 0 (No change)
Dimen: 1048 (old), 1048 (new), 0 (No change)
Drawable: 380 (old), 379 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1275 (old), 1275 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 380 (old), 380 (new), 0 (No change)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 850 (old), 850 (new), 0 (No change)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 9943 bytes (Removed)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 5079 bytes (Removed)
Method count: 259758 (old), 259760 (new), 2 (Added)
Resources: 6766 (old), 6765 (new), 1 (Removed)

Drawable: 335 (old), 334 (new), 1 (Removed)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 9419 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 3087 bytes (Removed)

Method count: 116054 (old), 116055 (new), 1 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5783 (new), 1 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 341 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 9383 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 5211 bytes (Removed)
Method count: 116054 (old), 116055 (new), 1 (Added)
Resources: 5741 (old), 5740 (new), 1 (Removed)

Drawable: 302 (old), 301 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 10 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 4492 bytes (Removed)

Method count: 116060 (old), 116061 (new), 1 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5783 (new), 1 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 341 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 10 MiB (new), 10 KiB (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 2221 bytes (Removed)
Method count: 116060 (old), 116061 (new), 1 (Added)
Resources: 5741 (old), 5740 (new), 1 (Removed)

Drawable: 302 (old), 301 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 10 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 7318 bytes (Removed)

Method count: 116060 (old), 116061 (new), 1 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5783 (new), 1 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 341 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 10 MiB (new), 10 KiB (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 3066 bytes (Removed)
Method count: 116060 (old), 116061 (new), 1 (Added)
Resources: 5741 (old), 5740 (new), 1 (Removed)

Drawable: 302 (old), 301 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

adhiamboperes

Thanks @TanishMoral11! PTAL at my suggestions.

Do not resolve reviewer comments, so that the reviewer can verify that they have been addressed.

adhiamboperes · 2024-11-07T14:51:44Z

app/src/main/java/org/oppia/android/app/player/audio/AudioViewModel.kt

+    if (newState == null || id == null) {
+      Log.e("AudioViewModel", "Failed to set state or id - parameters are null")
+      return
+    }


This is not needed. These values are passed in from the presenter, and we make an assumption that they are not null by the time they are passed in here.

Side note, we use our own logger, oppiaLogger for printing messages. It has w, i, and e just like Log.

adhiamboperes · 2024-11-07T14:52:08Z

app/src/main/java/org/oppia/android/app/player/audio/AudioViewModel.kt

    state = newState
    explorationId = id
  }

+


Remove double newline.

adhiamboperes · 2024-11-07T14:54:32Z

app/src/main/java/org/oppia/android/app/player/audio/AudioViewModel.kt

+    if (!::state.isInitialized || !::explorationId.isInitialized) {
+      Log.w("AudioViewModel", "Cannot load audio: state or explorationId is not initialized.")
+      return
+    }


Refactor this to:

Suggested change

if (!::state.isInitialized || !::explorationId.isInitialized) {

Log.w("AudioViewModel", "Cannot load audio: state or explorationId is not initialized.")

return

}

val targetContentId = when {

!contentId.isNullOrEmpty() -> contentId

::state.isInitialized -> state.content.contentId

else -> ""

}

which is more robust, adds a check for state.isInitialized and provides a final fallback ("") if neither contentId nor state.content.contentId is available. This version helps avoid potential crashes if state or contentId is unavailable.

oppiabot · 2024-11-07T14:59:51Z

Unassigning @adhiamboperes since the review is done.

oppiabot · 2024-11-07T14:59:54Z

Hi @TanishMoral11, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

TanishMoral11 · 2024-11-07T21:05:17Z

Hey @adhiamboperes,

I've successfully addressed all the required changes as per the feedback. Could you kindly take a look at the updates when you get a chance?
Thanks!!

github-actions · 2024-11-07T22:21:44Z

Coverage Report

Results

Number of files assessed: 117
Overall Coverage: 72.56%
Coverage Analysis: PASS ✅

Passing coverage

Files with passing code coverage

File	Coverage	Lines Hit	Status	Min Required
EventBundleCreator.kt utility/src/main/java/org/oppia/android/util/logging/EventBundleCreator.kt	75.93%	328 / 432	✅	70%
EventTypeToHumanReadableNameConverter.kt utility/src/main/java/org/oppia/android/util/logging/EventTypeToHumanReadableNameConverter.kt	100.00%	52 / 52	✅	70%
ActivityLanguageLocaleHandler.kt app/src/main/java/org/oppia/android/app/translation/ActivityLanguageLocaleHandler.kt	100.00%	11 / 11	✅	70%
AppLanguageWatcherMixin.kt app/src/main/java/org/oppia/android/app/translation/AppLanguageWatcherMixin.kt	72.22%	26 / 36	✅	70%
ActivityRouter.kt app/src/main/java/org/oppia/android/app/activity/route/ActivityRouter.kt	100.00%	12 / 12	✅	70%
ActivityIntentFactories.kt app/src/main/java/org/oppia/android/app/activity/ActivityIntentFactories.kt	0.00%	0 / 0	✅	0% *
InitializeDefaultLocaleRule.kt testing/src/main/java/org/oppia/android/testing/junit/InitializeDefaultLocaleRule.kt	38.24%	39 / 102	✅	38% *

* represents tests with custom overridden pass/fail coverage thresholds

Exempted coverage

Files exempted from coverage

File	Exemption Reason
LogReportingModule.kt utility/src/main/java/org/oppia/android/util/logging/firebase/LogReportingModule.kt	This file is exempted from having a test file; skipping coverage check.
SpotlightFragment.kt app/src/main/java/org/oppia/android/app/spotlight/SpotlightFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
PoliciesFragment.kt app/src/main/java/org/oppia/android/app/policies/PoliciesFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
PoliciesActivity.kt app/src/main/java/org/oppia/android/app/policies/PoliciesActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
MyDownloadsActivity.kt app/src/main/java/org/oppia/android/app/mydownloads/MyDownloadsActivity.kt	This file is exempted from having a test file; skipping coverage check.
MyDownloadsFragment.kt app/src/main/java/org/oppia/android/app/mydownloads/MyDownloadsFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
StoryActivity.kt app/src/main/java/org/oppia/android/app/story/StoryActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
StoryFragment.kt app/src/main/java/org/oppia/android/app/story/StoryFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
CompletedStoryListActivity.kt app/src/main/java/org/oppia/android/app/completedstorylist/CompletedStoryListActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AppLanguageActivity.kt app/src/main/java/org/oppia/android/app/options/AppLanguageActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
OptionsActivity.kt app/src/main/java/org/oppia/android/app/options/OptionsActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AudioLanguageFragment.kt app/src/main/java/org/oppia/android/app/options/AudioLanguageFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ReadingTextSizeActivity.kt app/src/main/java/org/oppia/android/app/options/ReadingTextSizeActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
OptionsFragment.kt app/src/main/java/org/oppia/android/app/options/OptionsFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AppLanguageFragment.kt app/src/main/java/org/oppia/android/app/options/AppLanguageFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AudioLanguageActivity.kt app/src/main/java/org/oppia/android/app/options/AudioLanguageActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ReadingTextSizeFragment.kt app/src/main/java/org/oppia/android/app/options/ReadingTextSizeFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AppLanguageResourceHandler.kt app/src/main/java/org/oppia/android/app/translation/AppLanguageResourceHandler.kt	This file is incompatible with code coverage tooling; skipping coverage check.
MathExpressionInteractionsView.kt app/src/main/java/org/oppia/android/app/customview/interaction/MathExpressionInteractionsView.kt	This file is incompatible with code coverage tooling; skipping coverage check.
LessonThumbnailImageView.kt app/src/main/java/org/oppia/android/app/customview/LessonThumbnailImageView.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ForcedAppDeprecationNoticeDialogFragment.kt app/src/main/java/org/oppia/android/app/notice/ForcedAppDeprecationNoticeDialogFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
GeneralAvailabilityUpgradeNoticeDialogFragment.kt app/src/main/java/org/oppia/android/app/notice/GeneralAvailabilityUpgradeNoticeDialogFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
OsDeprecationNoticeDialogFragment.kt app/src/main/java/org/oppia/android/app/notice/OsDeprecationNoticeDialogFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
BetaNoticeDialogFragment.kt app/src/main/java/org/oppia/android/app/notice/BetaNoticeDialogFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
OptionalAppDeprecationNoticeDialogFragment.kt app/src/main/java/org/oppia/android/app/notice/OptionalAppDeprecationNoticeDialogFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
MathExpressionAccessibilityUtil.kt app/src/main/java/org/oppia/android/app/utility/math/MathExpressionAccessibilityUtil.kt	This file is incompatible with code coverage tooling; skipping coverage check.
RatioExtensions.kt app/src/main/java/org/oppia/android/app/utility/RatioExtensions.kt	This file is incompatible with code coverage tooling; skipping coverage check.
DateTimeUtil.kt app/src/main/java/org/oppia/android/app/utility/datetime/DateTimeUtil.kt	This file is incompatible with code coverage tooling; skipping coverage check.
StateFragment.kt app/src/main/java/org/oppia/android/app/player/state/StateFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
BottomSheetOptionsMenu.kt app/src/main/java/org/oppia/android/app/player/exploration/BottomSheetOptionsMenu.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ExplorationActivity.kt app/src/main/java/org/oppia/android/app/player/exploration/ExplorationActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AudioViewModel.kt app/src/main/java/org/oppia/android/app/player/audio/AudioViewModel.kt	This file is exempted from having a test file; skipping coverage check.
AudioFragment.kt app/src/main/java/org/oppia/android/app/player/audio/AudioFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AlphaApplicationComponent.kt app/src/main/java/org/oppia/android/app/application/alpha/AlphaApplicationComponent.kt	This file is exempted from having a test file; skipping coverage check.
GaApplicationComponent.kt app/src/main/java/org/oppia/android/app/application/ga/GaApplicationComponent.kt	This file is exempted from having a test file; skipping coverage check.
DeveloperApplicationComponent.kt app/src/main/java/org/oppia/android/app/application/dev/DeveloperApplicationComponent.kt	This file is exempted from having a test file; skipping coverage check.
BetaApplicationComponent.kt app/src/main/java/org/oppia/android/app/application/beta/BetaApplicationComponent.kt	This file is exempted from having a test file; skipping coverage check.
ResumeLessonActivity.kt app/src/main/java/org/oppia/android/app/resumelesson/ResumeLessonActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ResumeLessonFragment.kt app/src/main/java/org/oppia/android/app/resumelesson/ResumeLessonFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ActivityRouterModule.kt app/src/main/java/org/oppia/android/app/activity/route/ActivityRouterModule.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ConceptCardFragment.kt app/src/main/java/org/oppia/android/app/topic/conceptcard/ConceptCardFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TopicActivity.kt app/src/main/java/org/oppia/android/app/topic/TopicActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TopicInfoFragment.kt app/src/main/java/org/oppia/android/app/topic/info/TopicInfoFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
RevisionCardActivity.kt app/src/main/java/org/oppia/android/app/topic/revisioncard/RevisionCardActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
RevisionCardFragment.kt app/src/main/java/org/oppia/android/app/topic/revisioncard/RevisionCardFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TopicPracticeFragment.kt app/src/main/java/org/oppia/android/app/topic/practice/TopicPracticeFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TopicFragment.kt app/src/main/java/org/oppia/android/app/topic/TopicFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
QuestionPlayerActivity.kt app/src/main/java/org/oppia/android/app/topic/questionplayer/QuestionPlayerActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TopicRevisionFragment.kt app/src/main/java/org/oppia/android/app/topic/revision/TopicRevisionFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TopicLessonsFragment.kt app/src/main/java/org/oppia/android/app/topic/lessons/TopicLessonsFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
HomeActivity.kt app/src/main/java/org/oppia/android/app/home/HomeActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
WelcomeViewModel.kt app/src/main/java/org/oppia/android/app/home/WelcomeViewModel.kt	This file is incompatible with code coverage tooling; skipping coverage check.
PromotedStoryViewModel.kt app/src/main/java/org/oppia/android/app/home/promotedlist/PromotedStoryViewModel.kt	This file is incompatible with code coverage tooling; skipping coverage check.
PromotedStoryListViewModel.kt app/src/main/java/org/oppia/android/app/home/promotedlist/PromotedStoryListViewModel.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileProgressFragment.kt app/src/main/java/org/oppia/android/app/profileprogress/ProfileProgressFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfilePictureActivity.kt app/src/main/java/org/oppia/android/app/profileprogress/ProfilePictureActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileProgressActivity.kt app/src/main/java/org/oppia/android/app/profileprogress/ProfileProgressActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
BindableAdapter.kt app/src/main/java/org/oppia/android/app/recyclerview/BindableAdapter.kt	This file is incompatible with code coverage tooling; skipping coverage check.
OngoingTopicListActivity.kt app/src/main/java/org/oppia/android/app/ongoingtopiclist/OngoingTopicListActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
HelpFragment.kt app/src/main/java/org/oppia/android/app/help/HelpFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
HelpActivity.kt app/src/main/java/org/oppia/android/app/help/HelpActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
WalkthroughActivity.kt app/src/main/java/org/oppia/android/app/walkthrough/WalkthroughActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
StringToRatioParser.kt app/src/main/java/org/oppia/android/app/parser/StringToRatioParser.kt	This file is incompatible with code coverage tooling; skipping coverage check.
FractionParsingUiError.kt app/src/main/java/org/oppia/android/app/parser/FractionParsingUiError.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileRenameFragment.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileRenameFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileListActivity.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileListActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileEditFragment.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditFragment.kt	This file is exempted from having a test file; skipping coverage check.
ProfileListFragment.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileListFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileEditActivity.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileResetPinActivity.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileResetPinActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileResetPinFragment.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileResetPinFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileRenameActivity.kt app/src/main/java/org/oppia/android/app/settings/profile/ProfileRenameActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
SurveyFragment.kt app/src/main/java/org/oppia/android/app/survey/SurveyFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
SurveyActivity.kt app/src/main/java/org/oppia/android/app/survey/SurveyActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ClassroomListFragment.kt app/src/main/java/org/oppia/android/app/classroom/ClassroomListFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ClassroomListActivity.kt app/src/main/java/org/oppia/android/app/classroom/ClassroomListActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
OnboardingFragment.kt app/src/main/java/org/oppia/android/app/onboarding/OnboardingFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
CreateProfileActivity.kt app/src/main/java/org/oppia/android/app/onboarding/CreateProfileActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
OnboardingProfileTypeActivity.kt app/src/main/java/org/oppia/android/app/onboarding/OnboardingProfileTypeActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
IntroFragment.kt app/src/main/java/org/oppia/android/app/onboarding/IntroFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
OnboardingActivity.kt app/src/main/java/org/oppia/android/app/onboarding/OnboardingActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
IntroActivity.kt app/src/main/java/org/oppia/android/app/onboarding/IntroActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
OnboardingProfileTypeFragment.kt app/src/main/java/org/oppia/android/app/onboarding/OnboardingProfileTypeFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
CreateProfileFragment.kt app/src/main/java/org/oppia/android/app/onboarding/CreateProfileFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
RatioInputInteractionViewTestActivity.kt app/src/main/java/org/oppia/android/app/testing/RatioInputInteractionViewTestActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
DragDropTestActivity.kt app/src/main/java/org/oppia/android/app/testing/DragDropTestActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TestFontScaleConfigurationUtilActivity.kt app/src/main/java/org/oppia/android/app/testing/TestFontScaleConfigurationUtilActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TestActivity.kt app/src/main/java/org/oppia/android/app/testing/activity/TestActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
FractionInputInteractionViewTestActivity.kt app/src/main/java/org/oppia/android/app/testing/FractionInputInteractionViewTestActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TopicTestActivityForStory.kt app/src/main/java/org/oppia/android/app/testing/TopicTestActivityForStory.kt	This file is incompatible with code coverage tooling; skipping coverage check.
InputInteractionViewTestActivity.kt app/src/main/java/org/oppia/android/app/testing/InputInteractionViewTestActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TextInputInteractionViewTestActivity.kt app/src/main/java/org/oppia/android/app/testing/TextInputInteractionViewTestActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AdminPinActivity.kt app/src/main/java/org/oppia/android/app/profile/AdminPinActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileChooserFragment.kt app/src/main/java/org/oppia/android/app/profile/ProfileChooserFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AdminAuthActivity.kt app/src/main/java/org/oppia/android/app/profile/AdminAuthActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileChooserActivity.kt app/src/main/java/org/oppia/android/app/profile/ProfileChooserActivity.kt	This file is exempted from having a test file; skipping coverage check.
PinPasswordActivity.kt app/src/main/java/org/oppia/android/app/profile/PinPasswordActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AddProfileActivity.kt app/src/main/java/org/oppia/android/app/profile/AddProfileActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
SplashActivity.kt app/src/main/java/org/oppia/android/app/splash/SplashActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileAndDeviceIdFragment.kt app/src/main/java/org/oppia/android/app/administratorcontrols/learneranalytics/ProfileAndDeviceIdFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ProfileAndDeviceIdActivity.kt app/src/main/java/org/oppia/android/app/administratorcontrols/learneranalytics/ProfileAndDeviceIdActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AdministratorControlsActivity.kt app/src/main/java/org/oppia/android/app/administratorcontrols/AdministratorControlsActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AdministratorControlsFragment.kt app/src/main/java/org/oppia/android/app/administratorcontrols/AdministratorControlsFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
DeveloperOptionsActivity.kt app/src/main/java/org/oppia/android/app/devoptions/DeveloperOptionsActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
DeveloperOptionsFragment.kt app/src/main/java/org/oppia/android/app/devoptions/DeveloperOptionsFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ForceNetworkTypeFragment.kt app/src/main/java/org/oppia/android/app/devoptions/forcenetworktype/ForceNetworkTypeFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
ForceNetworkTypeActivity.kt app/src/main/java/org/oppia/android/app/devoptions/forcenetworktype/ForceNetworkTypeActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
MathExpressionParserActivity.kt app/src/main/java/org/oppia/android/app/devoptions/mathexpressionparser/MathExpressionParserActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.
MathExpressionParserFragment.kt app/src/main/java/org/oppia/android/app/devoptions/mathexpressionparser/MathExpressionParserFragment.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TestApplicationComponent.kt instrumentation/src/java/org/oppia/android/instrumentation/application/TestApplicationComponent.kt	This file is exempted from having a test file; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

github-actions · 2024-11-09T04:31:48Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 4643 bytes (Removed)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 340 bytes (Removed)

Method count: 259592 (old), 259758 (new), 166 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6816 (old), 6815 (new), 1 (Removed)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 967 (old), 967 (new), 0 (No change)
Dimen: 1048 (old), 1048 (new), 0 (No change)
Drawable: 380 (old), 379 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1275 (old), 1275 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 380 (old), 380 (new), 0 (No change)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 850 (old), 850 (new), 0 (No change)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 4607 bytes (Removed)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 1007 bytes (Added)
Method count: 259592 (old), 259758 (new), 166 (Added)
Resources: 6766 (old), 6765 (new), 1 (Removed)

Drawable: 335 (old), 334 (new), 1 (Removed)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 1 bytes (Removed)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 1 bytes (Added)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 1 bytes (Removed)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 1 bytes (Removed)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 9935 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 4108 bytes (Removed)

Method count: 116052 (old), 116054 (new), 2 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5783 (new), 1 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 341 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 9899 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 4833 bytes (Removed)
Method count: 116052 (old), 116054 (new), 2 (Added)
Resources: 5741 (old), 5740 (new), 1 (Removed)

Drawable: 302 (old), 301 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 1 bytes (Removed)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 2 bytes (Removed)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 3 bytes (Added)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 1 bytes (Removed)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 1 bytes (Added)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 1 bytes (Added)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 11 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 10 KiB (Removed)

Method count: 116058 (old), 116060 (new), 2 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5783 (new), 1 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 341 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 10 MiB (new), 11 KiB (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 5781 bytes (Removed)
Method count: 116058 (old), 116060 (new), 2 (Added)
Resources: 5741 (old), 5740 (new), 1 (Removed)

Drawable: 302 (old), 301 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 2 bytes (Removed)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 1 bytes (Added)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 1 bytes (Removed)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 11 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 7864 bytes (Removed)

Method count: 116058 (old), 116060 (new), 2 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5783 (new), 1 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 341 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 10 MiB (new), 10 KiB (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 3698 bytes (Removed)
Method count: 116058 (old), 116060 (new), 2 (Added)
Resources: 5741 (old), 5740 (new), 1 (Removed)

Drawable: 302 (old), 301 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 1 bytes (Added)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 1 bytes (Removed)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 1 bytes (Added)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 2 bytes (Added)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 1 bytes (Removed)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

github-actions · 2024-11-11T04:37:36Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 4643 bytes (Removed)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 340 bytes (Removed)

Method count: 259592 (old), 259758 (new), 166 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6816 (old), 6815 (new), 1 (Removed)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 967 (old), 967 (new), 0 (No change)
Dimen: 1048 (old), 1048 (new), 0 (No change)
Drawable: 380 (old), 379 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1275 (old), 1275 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 380 (old), 380 (new), 0 (No change)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 850 (old), 850 (new), 0 (No change)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 4607 bytes (Removed)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 1007 bytes (Added)
Method count: 259592 (old), 259758 (new), 166 (Added)
Resources: 6766 (old), 6765 (new), 1 (Removed)

Drawable: 335 (old), 334 (new), 1 (Removed)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 1 bytes (Removed)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 1 bytes (Added)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 1 bytes (Removed)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 1 bytes (Removed)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 9935 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 4108 bytes (Removed)

Method count: 116052 (old), 116054 (new), 2 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5783 (new), 1 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 341 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 9899 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 4833 bytes (Removed)
Method count: 116052 (old), 116054 (new), 2 (Added)
Resources: 5741 (old), 5740 (new), 1 (Removed)

Drawable: 302 (old), 301 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 1 bytes (Removed)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 2 bytes (Removed)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 3 bytes (Added)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 1 bytes (Removed)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 1 bytes (Added)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 1 bytes (Added)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 11 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 10 KiB (Removed)

Method count: 116058 (old), 116060 (new), 2 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5783 (new), 1 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 341 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 10 MiB (new), 11 KiB (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 5781 bytes (Removed)
Method count: 116058 (old), 116060 (new), 2 (Added)
Resources: 5741 (old), 5740 (new), 1 (Removed)

Drawable: 302 (old), 301 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 2 bytes (Removed)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 1 bytes (Added)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 1 bytes (Removed)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 11 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 7864 bytes (Removed)

Method count: 116058 (old), 116060 (new), 2 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5783 (new), 1 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 341 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 10 MiB (new), 10 KiB (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 3698 bytes (Removed)
Method count: 116058 (old), 116060 (new), 2 (Added)
Resources: 5741 (old), 5740 (new), 1 (Removed)

Drawable: 302 (old), 301 (new), 1 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 1 bytes (Added)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 1 bytes (Removed)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 1 bytes (Added)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 2 bytes (Added)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 1 bytes (Removed)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

TanishMoral11 · 2024-11-13T09:05:15Z

Hey @adhiamboperes PTAL
Thanks !!

oppiabot · 2024-11-13T09:23:32Z

Unassigning @TanishMoral11 since a re-review was requested. @TanishMoral11, please make sure you have addressed all review comments. Thanks!

Fix crash in AudioViewModel by initializing state variables

0dc284f

TanishMoral11 requested a review from a team as a code owner October 28, 2024 07:24

TanishMoral11 requested a review from adhiamboperes October 28, 2024 07:24

TanishMoral11 changed the title ~~**Fix #2652: Resolve crash in AudioViewModel by initializing state variables**~~ Fix #2652: Resolve crash in AudioViewModel by initializing state variables Oct 28, 2024

TanishMoral11 changed the title ~~Fix #2652: Resolve crash in AudioViewModel by initializing state variables~~ Fix #5455: Resolve crash in AudioViewModel by initializing state variables Oct 28, 2024

TanishMoral11 mentioned this pull request Oct 28, 2024

[BUG]: The app crashes occasionally when the device is rotated during exploration. #5455

Open

Vishwajith-Shettigar assigned adhiamboperes Oct 28, 2024

adhiamboperes requested changes Oct 29, 2024

View reviewed changes

adhiamboperes assigned TanishMoral11 and unassigned adhiamboperes Oct 29, 2024

Fix crash in AudioViewModel on rotation by ensuring state initialization

30ca796

oppiabot bot assigned adhiamboperes and unassigned TanishMoral11 Oct 30, 2024

adhiamboperes requested changes Nov 7, 2024

View reviewed changes

oppiabot bot unassigned adhiamboperes Nov 7, 2024

oppiabot bot assigned TanishMoral11 Nov 7, 2024

TanishMoral11 added 2 commits November 8, 2024 02:29

AudioViewModel: resolved changes

418e0c5

Remove Unnecessary Lines

18452ca

oppiabot bot assigned adhiamboperes and unassigned TanishMoral11 Nov 13, 2024

	if (playerFeatureSet.supportAudioVoiceovers) {
	val processedStateName = ephemeralState.state.name
	val audioManager = getAudioUiManager()
	val activityId = checkNotNull(audioActivityId) {
	"Expected the audio activity ID to be set when voiceovers are enabled"
	}
	audioManager?.setStateAndExplorationId(ephemeralState.state, activityId)

-    if (!::state.isInitialized || !::explorationId.isInitialized) {
-      Log.w("AudioViewModel", "Cannot load audio: state or explorationId is not initialized.")
-      return
-    }
+     val targetContentId = when {
+      !contentId.isNullOrEmpty() -> contentId
+      ::state.isInitialized -> state.content.contentId
+      else -> ""
+    }

Fix #5455: Resolve crash in AudioViewModel by initializing state variables #5561

Are you sure you want to change the base?

Fix #5455: Resolve crash in AudioViewModel by initializing state variables #5561

Conversation

TanishMoral11 commented Oct 28, 2024 • edited Loading

github-actions bot commented Oct 29, 2024

APK & AAB differences analysis

Dev

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Alpha

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Beta

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Ga

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

adhiamboperes left a comment

Choose a reason for hiding this comment

adhiamboperes Oct 28, 2024

Choose a reason for hiding this comment

TanishMoral11 Oct 29, 2024

Choose a reason for hiding this comment

adhiamboperes Oct 29, 2024

Choose a reason for hiding this comment

TanishMoral11 Oct 29, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 30, 2024

APK & AAB differences analysis

Dev

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Alpha

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

TanishMoral11 commented Oct 28, 2024 •

edited

Loading