Fixes #3641 Use finish() instead of intent for smoother navigation #5557

theayushyadav11 · 2024-10-21T18:15:25Z

Description:

Fixes Investigate using finish instead of intent #3641
This PR simplifies the navigation logic in AddProfileActivity and documents the reasoning behind not using finish() in ExitProfileDialogFragment.

Changes Made:

AddProfileActivity:
- Replaced the use of Intent with FLAG_ACTIVITY_CLEAR_TOP by calling finish().
- With the live data bug resolved, the activity stack can now be managed more cleanly without requiring a new intent.
Benefits:
- Avoids unnecessary activity recreation.
- Improves navigation efficiency and reduces overhead.
ExitProfileDialogFragment:
- Retained the use of an Intent to navigate to ProfileChooserActivity instead of switching to finish().
- Reason:
  - ProfileChooserActivity is not directly below the current activity in the stack.
  - If finish() were used, the app would incorrectly navigate to PinPasswordActivity, resulting in undesirable behavior.

Testing:

Verified that AddProfileActivity correctly navigates back to ProfileChooserActivity using finish() without activity recreation.
Confirmed that ExitProfileDialogFragment behaves as expected, retaining the correct navigation path through Intent to ProfileChooserActivity.

Summary:

This PR ensures cleaner navigation for AddProfileActivity by using finish(), while maintaining correct behavior in ExitProfileDialogFragment by continuing to use an intent-based approach. This makes the app more efficient while preserving user experience.

Video Demo as everything is working fine.

demo.1.mov

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

github-actions · 2024-10-24T04:15:37Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 23 KiB (Removed)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 22 KiB (Removed)

Method count: 259758 (old), 259183 (new), 575 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6815 (old), 6808 (new), 7 (Removed)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 967 (old), 967 (new), 0 (No change)
Dimen: 1048 (old), 1048 (new), 0 (No change)
Drawable: 379 (old), 379 (new), 0 (No change)
Id: 1275 (old), 1272 (new), 3 (Removed):
- id/onboarding_language_dropdown (removed)
- id/test_autocomplete_view (removed)
- id/test_text_input_view (removed)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 380 (old), 378 (new), 2 (Removed):
- layout/text_input_layout_binding_adapters_test_activity (removed)
- layout/text_input_layout_binding_adapters_test_fragment (removed)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 850 (old), 848 (new), 2 (Removed):
- string/add_profile_default_error_message (removed)
- string/add_profile_error_missing_profile_type (removed)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 23 KiB (Removed)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 23 KiB (Removed)
Method count: 259758 (old), 259183 (new), 575 (Removed)
Resources: 6765 (old), 6758 (new), 7 (Removed)

Id: 1275 (old), 1272 (new), 3 (Removed)
Layout: 380 (old), 378 (new), 2 (Removed)
String: 850 (old), 848 (new), 2 (Removed)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 17 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 19 KiB (Removed)

Method count: 116054 (old), 115727 (new), 327 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5783 (old), 5776 (new), 7 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 341 (old), 341 (new), 0 (No change)
Id: 1221 (old), 1218 (new), 3 (Removed):
- id/onboarding_language_dropdown (removed)
- id/test_autocomplete_view (removed)
- id/test_text_input_view (removed)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 341 (new), 2 (Removed):
- layout/text_input_layout_binding_adapters_test_activity (removed)
- layout/text_input_layout_binding_adapters_test_fragment (removed)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 781 (new), 2 (Removed):
- string/add_profile_default_error_message (removed)
- string/add_profile_error_missing_profile_type (removed)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 17 KiB (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 17 KiB (Removed)
Method count: 116054 (old), 115727 (new), 327 (Removed)
Resources: 5740 (old), 5733 (new), 7 (Removed)

Id: 1221 (old), 1218 (new), 3 (Removed)
Layout: 343 (old), 341 (new), 2 (Removed)
String: 783 (old), 781 (new), 2 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 17 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 18 KiB (Removed)

Method count: 116060 (old), 115733 (new), 327 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5783 (old), 5776 (new), 7 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 341 (old), 341 (new), 0 (No change)
Id: 1221 (old), 1218 (new), 3 (Removed):
- id/onboarding_language_dropdown (removed)
- id/test_autocomplete_view (removed)
- id/test_text_input_view (removed)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 341 (new), 2 (Removed):
- layout/text_input_layout_binding_adapters_test_activity (removed)
- layout/text_input_layout_binding_adapters_test_fragment (removed)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 781 (new), 2 (Removed):
- string/add_profile_default_error_message (removed)
- string/add_profile_error_missing_profile_type (removed)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 17 KiB (Removed)
APK download size (estimated): 10 MiB (old), 9 MiB (new), 18 KiB (Removed)
Method count: 116060 (old), 115733 (new), 327 (Removed)
Resources: 5740 (old), 5733 (new), 7 (Removed)

Id: 1221 (old), 1218 (new), 3 (Removed)
Layout: 343 (old), 341 (new), 2 (Removed)
String: 783 (old), 781 (new), 2 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 17 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 17 KiB (Removed)

Method count: 116060 (old), 115733 (new), 327 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5783 (old), 5776 (new), 7 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 341 (old), 341 (new), 0 (No change)
Id: 1221 (old), 1218 (new), 3 (Removed):
- id/onboarding_language_dropdown (removed)
- id/test_autocomplete_view (removed)
- id/test_text_input_view (removed)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 341 (new), 2 (Removed):
- layout/text_input_layout_binding_adapters_test_activity (removed)
- layout/text_input_layout_binding_adapters_test_fragment (removed)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 781 (new), 2 (Removed):
- string/add_profile_default_error_message (removed)
- string/add_profile_error_missing_profile_type (removed)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 17 KiB (Removed)
APK download size (estimated): 10 MiB (old), 9 MiB (new), 17 KiB (Removed)
Method count: 116060 (old), 115733 (new), 327 (Removed)
Resources: 5740 (old), 5733 (new), 7 (Removed)

Id: 1221 (old), 1218 (new), 3 (Removed)
Layout: 343 (old), 341 (new), 2 (Removed)
String: 783 (old), 781 (new), 2 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

github-actions · 2024-10-26T04:14:01Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 23 KiB (Removed)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 22 KiB (Removed)

Method count: 259758 (old), 259183 (new), 575 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6815 (old), 6808 (new), 7 (Removed)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 967 (old), 967 (new), 0 (No change)
Dimen: 1048 (old), 1048 (new), 0 (No change)
Drawable: 379 (old), 379 (new), 0 (No change)
Id: 1275 (old), 1272 (new), 3 (Removed):
- id/onboarding_language_dropdown (removed)
- id/test_autocomplete_view (removed)
- id/test_text_input_view (removed)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 380 (old), 378 (new), 2 (Removed):
- layout/text_input_layout_binding_adapters_test_activity (removed)
- layout/text_input_layout_binding_adapters_test_fragment (removed)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 850 (old), 848 (new), 2 (Removed):
- string/add_profile_default_error_message (removed)
- string/add_profile_error_missing_profile_type (removed)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 23 KiB (Removed)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 23 KiB (Removed)
Method count: 259758 (old), 259183 (new), 575 (Removed)
Resources: 6765 (old), 6758 (new), 7 (Removed)

Id: 1275 (old), 1272 (new), 3 (Removed)
Layout: 380 (old), 378 (new), 2 (Removed)
String: 850 (old), 848 (new), 2 (Removed)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 17 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 19 KiB (Removed)

Method count: 116054 (old), 115727 (new), 327 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5783 (old), 5776 (new), 7 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 341 (old), 341 (new), 0 (No change)
Id: 1221 (old), 1218 (new), 3 (Removed):
- id/onboarding_language_dropdown (removed)
- id/test_autocomplete_view (removed)
- id/test_text_input_view (removed)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 341 (new), 2 (Removed):
- layout/text_input_layout_binding_adapters_test_activity (removed)
- layout/text_input_layout_binding_adapters_test_fragment (removed)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 781 (new), 2 (Removed):
- string/add_profile_default_error_message (removed)
- string/add_profile_error_missing_profile_type (removed)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 17 KiB (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 17 KiB (Removed)
Method count: 116054 (old), 115727 (new), 327 (Removed)
Resources: 5740 (old), 5733 (new), 7 (Removed)

Id: 1221 (old), 1218 (new), 3 (Removed)
Layout: 343 (old), 341 (new), 2 (Removed)
String: 783 (old), 781 (new), 2 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 17 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 18 KiB (Removed)

Method count: 116060 (old), 115733 (new), 327 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5783 (old), 5776 (new), 7 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 341 (old), 341 (new), 0 (No change)
Id: 1221 (old), 1218 (new), 3 (Removed):
- id/onboarding_language_dropdown (removed)
- id/test_autocomplete_view (removed)
- id/test_text_input_view (removed)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 341 (new), 2 (Removed):
- layout/text_input_layout_binding_adapters_test_activity (removed)
- layout/text_input_layout_binding_adapters_test_fragment (removed)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 781 (new), 2 (Removed):
- string/add_profile_default_error_message (removed)
- string/add_profile_error_missing_profile_type (removed)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 17 KiB (Removed)
APK download size (estimated): 10 MiB (old), 9 MiB (new), 18 KiB (Removed)
Method count: 116060 (old), 115733 (new), 327 (Removed)
Resources: 5740 (old), 5733 (new), 7 (Removed)

Id: 1221 (old), 1218 (new), 3 (Removed)
Layout: 343 (old), 341 (new), 2 (Removed)
String: 783 (old), 781 (new), 2 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 17 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 17 KiB (Removed)

Method count: 116060 (old), 115733 (new), 327 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5783 (old), 5776 (new), 7 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 341 (old), 341 (new), 0 (No change)
Id: 1221 (old), 1218 (new), 3 (Removed):
- id/onboarding_language_dropdown (removed)
- id/test_autocomplete_view (removed)
- id/test_text_input_view (removed)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 341 (new), 2 (Removed):
- layout/text_input_layout_binding_adapters_test_activity (removed)
- layout/text_input_layout_binding_adapters_test_fragment (removed)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 781 (new), 2 (Removed):
- string/add_profile_default_error_message (removed)
- string/add_profile_error_missing_profile_type (removed)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 17 KiB (Removed)
APK download size (estimated): 10 MiB (old), 9 MiB (new), 17 KiB (Removed)
Method count: 116060 (old), 115733 (new), 327 (Removed)
Resources: 5740 (old), 5733 (new), 7 (Removed)

Id: 1221 (old), 1218 (new), 3 (Removed)
Layout: 343 (old), 341 (new), 2 (Removed)
String: 783 (old), 781 (new), 2 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

adhiamboperes

Thanks @theayushyadav11!

I have a few comments:

Re - UI tests. You can add a test for this change in te corresponding test file. You can base your test on this other one: https://github.com/oppia/oppia-android/blob/2301a52eae08f271fd4090e51470696f223c135a/app/src/sharedTest/java/org/oppia/android/app/onboarding/IntroFragmentTest.kt#L176C1-L187. Also, to invoke onSupportNavigateUp in Espresso, you can take a look at https://stackoverflow.com/a/42872727.
I agree with your assessment of ExitProfileDialogFragment.kt#L67, but in order for the issue to be closed, you have to remove the TODO from the code. It would also be great to add the reason for this in the issue thread to make future investigation easier.
A screen recording oof the changes is usually required as an extra step to ensure the changes do what is promised.

oppiabot · 2024-10-28T13:22:23Z

Unassigning @adhiamboperes since the review is done.

oppiabot · 2024-10-28T13:22:26Z

Hi @theayushyadav11, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

github-actions · 2024-11-05T04:42:55Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 33 KiB (Removed)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 24 KiB (Removed)

Method count: 259758 (old), 259183 (new), 575 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6816 (old), 6808 (new), 8 (Removed)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 967 (old), 967 (new), 0 (No change)
Dimen: 1048 (old), 1048 (new), 0 (No change)
Drawable: 380 (old), 379 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1275 (old), 1272 (new), 3 (Removed):
- id/onboarding_language_dropdown (removed)
- id/test_autocomplete_view (removed)
- id/test_text_input_view (removed)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 380 (old), 378 (new), 2 (Removed):
- layout/text_input_layout_binding_adapters_test_activity (removed)
- layout/text_input_layout_binding_adapters_test_fragment (removed)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 850 (old), 848 (new), 2 (Removed):
- string/add_profile_default_error_message (removed)
- string/add_profile_error_missing_profile_type (removed)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 33 KiB (Removed)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 27 KiB (Removed)
Method count: 259758 (old), 259183 (new), 575 (Removed)
Resources: 6766 (old), 6758 (new), 8 (Removed)

Drawable: 335 (old), 334 (new), 1 (Removed)
Id: 1275 (old), 1272 (new), 3 (Removed)
Layout: 380 (old), 378 (new), 2 (Removed)
String: 850 (old), 848 (new), 2 (Removed)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 27 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 22 KiB (Removed)

Method count: 116054 (old), 115727 (new), 327 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5776 (new), 8 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 341 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1221 (old), 1218 (new), 3 (Removed):
- id/onboarding_language_dropdown (removed)
- id/test_autocomplete_view (removed)
- id/test_text_input_view (removed)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 341 (new), 2 (Removed):
- layout/text_input_layout_binding_adapters_test_activity (removed)
- layout/text_input_layout_binding_adapters_test_fragment (removed)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 781 (new), 2 (Removed):
- string/add_profile_default_error_message (removed)
- string/add_profile_error_missing_profile_type (removed)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 27 KiB (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 23 KiB (Removed)
Method count: 116054 (old), 115727 (new), 327 (Removed)
Resources: 5741 (old), 5733 (new), 8 (Removed)

Drawable: 302 (old), 301 (new), 1 (Removed)
Id: 1221 (old), 1218 (new), 3 (Removed)
Layout: 343 (old), 341 (new), 2 (Removed)
String: 783 (old), 781 (new), 2 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 27 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 22 KiB (Removed)

Method count: 116060 (old), 115733 (new), 327 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5776 (new), 8 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 341 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1221 (old), 1218 (new), 3 (Removed):
- id/onboarding_language_dropdown (removed)
- id/test_autocomplete_view (removed)
- id/test_text_input_view (removed)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 341 (new), 2 (Removed):
- layout/text_input_layout_binding_adapters_test_activity (removed)
- layout/text_input_layout_binding_adapters_test_fragment (removed)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 781 (new), 2 (Removed):
- string/add_profile_default_error_message (removed)
- string/add_profile_error_missing_profile_type (removed)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 10 MiB (new), 27 KiB (Removed)
APK download size (estimated): 10 MiB (old), 9 MiB (new), 20 KiB (Removed)
Method count: 116060 (old), 115733 (new), 327 (Removed)
Resources: 5741 (old), 5733 (new), 8 (Removed)

Drawable: 302 (old), 301 (new), 1 (Removed)
Id: 1221 (old), 1218 (new), 3 (Removed)
Layout: 343 (old), 341 (new), 2 (Removed)
String: 783 (old), 781 (new), 2 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 28 KiB (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 24 KiB (Removed)

Method count: 116060 (old), 115733 (new), 327 (Removed)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5776 (new), 8 (Removed)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 341 (new), 1 (Removed):
- drawable/splash_image (removed)
Id: 1221 (old), 1218 (new), 3 (Removed):
- id/onboarding_language_dropdown (removed)
- id/test_autocomplete_view (removed)
- id/test_text_input_view (removed)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 341 (new), 2 (Removed):
- layout/text_input_layout_binding_adapters_test_activity (removed)
- layout/text_input_layout_binding_adapters_test_fragment (removed)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 781 (new), 2 (Removed):
- string/add_profile_default_error_message (removed)
- string/add_profile_error_missing_profile_type (removed)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 10 MiB (new), 28 KiB (Removed)
APK download size (estimated): 10 MiB (old), 9 MiB (new), 20 KiB (Removed)
Method count: 116060 (old), 115733 (new), 327 (Removed)
Resources: 5741 (old), 5733 (new), 8 (Removed)

Drawable: 302 (old), 301 (new), 1 (Removed)
Id: 1221 (old), 1218 (new), 3 (Removed)
Layout: 343 (old), 341 (new), 2 (Removed)
String: 783 (old), 781 (new), 2 (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

adhiamboperes · 2024-11-06T11:39:18Z

@theayushyadav11, friendly ping on this issue.

theayushyadav11 · 2024-11-07T10:53:10Z

@adhiamboperes PTAL.

oppiabot · 2024-11-07T10:56:15Z

Unassigning @theayushyadav11 since a re-review was requested. @theayushyadav11, please make sure you have addressed all review comments. Thanks!

adhiamboperes

Thanks @theayushyadav11!

You need to add a test for the backpress for AddProfileActivity.kt. I left a suggestion in my previous review comment. PTAL. Please also feel free to ask incase you face difficulty setting up the test.

app/src/main/java/org/oppia/android/app/profile/AddProfileActivity.kt

.idea/codeStyles/Project.xml

oppiabot · 2024-11-07T15:27:03Z

Unassigning @adhiamboperes since the review is done.

oppiabot · 2024-11-07T15:27:06Z

Hi @theayushyadav11, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

oppiabot · 2024-11-13T15:41:57Z

Unassigning @theayushyadav11 since a re-review was requested. @theayushyadav11, please make sure you have addressed all review comments. Thanks!

theayushyadav11 · 2024-11-14T12:44:07Z

Hey @adhiamboperes PTAL .

adhiamboperes

Thanks @theayushyadav11.

The solution and test look good, but cleanup is needed to get the PR merge ready. Please pull latest changes from develop and resolve the merge conflicts.

app/src/sharedTest/java/org/oppia/android/app/profile/AddProfileActivityTest.kt

.idea/codeStyles/Project.xml

…nish

…d into usingFinish

theayushyadav11 · 2024-11-14T18:47:56Z

Hey @adhiamboperes PTAL.

oppiabot · 2024-11-14T18:51:01Z

Unassigning @theayushyadav11 since a re-review was requested. @theayushyadav11, please make sure you have addressed all review comments. Thanks!

github-actions · 2024-11-15T05:03:05Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 632 bytes (Added)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 246 bytes (Added)

Method count: 259594 (old), 259594 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6816 (old), 6816 (new), 0 (No change)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 967 (old), 967 (new), 0 (No change)
Dimen: 1048 (old), 1048 (new), 0 (No change)
Drawable: 380 (old), 380 (new), 0 (No change)
Id: 1275 (old), 1275 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 380 (old), 380 (new), 0 (No change)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 850 (old), 850 (new), 0 (No change)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 632 bytes (Added)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 214 bytes (Added)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 48 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 661 bytes (Removed)

Method count: 116054 (old), 116054 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5784 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 48 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 3033 bytes (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 120 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 1257 bytes (Removed)

Method count: 116060 (old), 116060 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5784 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 124 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 31 bytes (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 64 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 491 bytes (Added)

Method count: 116060 (old), 116060 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5784 (old), 5784 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 820 (old), 820 (new), 0 (No change)
Dimen: 780 (old), 780 (new), 0 (No change)
Drawable: 342 (old), 342 (new), 0 (No change)
Id: 1221 (old), 1221 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 343 (old), 343 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 783 (old), 783 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 64 bytes (Removed)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 434 bytes (Removed)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

github-actions · 2024-11-15T08:50:53Z

Coverage Report

Results

Number of files assessed: 2
Overall Coverage: 0.00%
Coverage Analysis: PASS ✅

Exempted coverage

Files exempted from coverage

File	Exemption Reason
ExitProfileDialogFragment.kt app/src/main/java/org/oppia/android/app/drawer/ExitProfileDialogFragment.kt	This file is exempted from having a test file; skipping coverage check.
AddProfileActivity.kt app/src/main/java/org/oppia/android/app/profile/AddProfileActivity.kt	This file is incompatible with code coverage tooling; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

adhiamboperes

Thanks @theayushyadav11. Excellent work here. This LGTM!

github-actions · 2024-11-15T08:54:34Z

✨ Fantastic work @theayushyadav11! Your very first PR to Oppia has been merged! 🎉🥳

You've just taken your first step into open-source, and we couldn’t be happier to have you onboard. 🙌
If you're feeling adventurous, why not dive into another issue and keep contributing? The community would love to see more from you! 🚀

For any support, feel free to reach out to the developer onboarding lead: @adhiamboperes. Happy coding! 👩‍💻👨‍💻

Fix: Use finish() instead of intent for smoother navigation (oppia#3641)

54c7bd1

theayushyadav11 requested a review from a team as a code owner October 21, 2024 18:15

theayushyadav11 requested a review from adhiamboperes October 21, 2024 18:15

adhiamboperes self-assigned this Oct 23, 2024

adhiamboperes requested changes Oct 28, 2024

View reviewed changes

oppiabot bot unassigned adhiamboperes Oct 28, 2024

oppiabot bot assigned theayushyadav11 Oct 28, 2024

Removed TODO

32b1dca

theayushyadav11 requested a review from a team as a code owner November 7, 2024 10:52

theayushyadav11 requested a review from BenHenning November 7, 2024 10:52

oppiabot bot assigned adhiamboperes and unassigned theayushyadav11 Nov 7, 2024

adhiamboperes requested changes Nov 7, 2024

View reviewed changes

app/src/main/java/org/oppia/android/app/profile/AddProfileActivity.kt Outdated Show resolved Hide resolved

.idea/codeStyles/Project.xml Outdated Show resolved Hide resolved

oppiabot bot unassigned adhiamboperes Nov 7, 2024

oppiabot bot assigned theayushyadav11 Nov 7, 2024

Added test for BackPress

6fb90cd

oppiabot bot assigned adhiamboperes and unassigned theayushyadav11 Nov 13, 2024

added test for BackPress

5c73e27

adhiamboperes requested changes Nov 14, 2024

View reviewed changes

adhiamboperes assigned theayushyadav11 and unassigned adhiamboperes Nov 14, 2024

theayushyadav11 added 4 commits November 14, 2024 23:17

Merge branch 'develop' of github.com:oppia/oppia-android into usingFi…

defee21

…nish

Brought the deleted file back and fixed the code structure

1a9fc26

Merge branch 'develop' of github.com:oppia/oppia-android into usingFi…

8c3955d

…nish

Merge branch 'usingFinish' of github.com:theayushyadav11/oppia-androi…

4eb4269

…d into usingFinish

oppiabot bot assigned adhiamboperes and unassigned theayushyadav11 Nov 14, 2024

adhiamboperes approved these changes Nov 15, 2024

View reviewed changes

adhiamboperes merged commit 8a7fe0a into oppia:develop Nov 15, 2024
43 checks passed

theayushyadav11 deleted the usingFinish branch November 15, 2024 10:20

Fixes #3641 Use finish() instead of intent for smoother navigation #5557

Fixes #3641 Use finish() instead of intent for smoother navigation #5557

Conversation

theayushyadav11 commented Oct 21, 2024 • edited Loading

Description:

Changes Made:

Testing:

Summary:

Video Demo as everything is working fine.

Essential Checklist

github-actions bot commented Oct 24, 2024

APK & AAB differences analysis

Dev

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Alpha

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Beta

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Ga

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

github-actions bot commented Oct 26, 2024

APK & AAB differences analysis

Dev

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Alpha

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

theayushyadav11 commented Oct 21, 2024 •

edited

Loading