Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2711 & part of #5343: Workflow cancellation support in CI using concurrency #5466

Merged
merged 21 commits into from
Jul 29, 2024
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
f1bafb2
Workflow cancellation with concurrency
Rd4dev Jul 23, 2024
1bd7dc0
Trigger #1 Triggering CI builds to check workflow cancellations with …
Rd4dev Jul 23, 2024
9ea4511
Trigger #2 Triggering CI builds #1 worked as expected with 75% of wor…
Rd4dev Jul 23, 2024
c215fdc
Trigger #3 Triggering CI builds #2 worked as expected with 20% of wor…
Rd4dev Jul 23, 2024
66816be
Merge branch 'develop' of https://github.com/Rd4dev/oppia-android int…
Rd4dev Jul 24, 2024
dc1ab3b
Trigger Build to observe how Non-app module checks gets cut off
Rd4dev Jul 28, 2024
ef9f571
Triggering at Utility Build stage after Build Apps step is over
Rd4dev Jul 28, 2024
3398359
Trigger Build before Build App stage
Rd4dev Jul 28, 2024
0ee5f80
Triggering instance to see if always is causing the delay
Rd4dev Jul 28, 2024
2118891
Triggering to see if always is causing the delay with Static Checks
Rd4dev Jul 28, 2024
e9c3d60
Replacing always with !cancelled to not get affected by success and f…
Rd4dev Jul 28, 2024
6f54fd0
Triggering immediately after replacing always with !cancelled to see …
Rd4dev Jul 28, 2024
11a0560
Adding !cancelled to unit tests Check Results job while having a forc…
Rd4dev Jul 28, 2024
5eabb1d
Triggering after the TestFileCheck failure run
Rd4dev Jul 28, 2024
20d9450
Replacing all always expressions with !cancelled since the unit test …
Rd4dev Jul 28, 2024
125d30e
Triggering immediately after replacing every always expression to con…
Rd4dev Jul 28, 2024
10778b9
Triggering to confirm every job is getting cancelled immediately with…
Rd4dev Jul 28, 2024
6e5112f
Added in-line comments for explaining the introduction of if: {{ !can…
Rd4dev Jul 28, 2024
e73ae04
Added missed out period at the end of the in line comments
Rd4dev Jul 28, 2024
076687e
Triggering since a Run app module job was failing
Rd4dev Jul 28, 2024
e9ebf29
Triggering once again inbetween the previous check to confirm they ge…
Rd4dev Jul 28, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/build_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ on:
# Push events on develop branch
- develop

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
bazel_build_app:
name: Build Binary with Bazel
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ on:
# Push events on develop branch
- develop

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

# This workflow has the following jobs:
# robolectric_tests: Robolectric tests for all modules except the app module
# app_tests: Non-flaky Robolectric tests for the app module
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/static_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ on:
branches:
- develop

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
check_codeowners:
name: Check CODEOWNERS & Repository files
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/unit_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ on:
# Push events on develop branch
- develop

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
bazel_compute_affected_targets:
name: Compute affected tests
Expand Down
23 changes: 0 additions & 23 deletions .github/workflows/workflow_canceller.yml

This file was deleted.

Loading