-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4042: Implement success criteria metrics for lesson checkpointing #5336
Fix #4042: Implement success criteria metrics for lesson checkpointing #5336
Conversation
Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
@adhiamboperes PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @theMr17!
I have left a comment on the failing eventlog test, please let me know if I need to clarify it further.
@adhiamboperes PTAL. I have reintroduced the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @theMr17! This LGTM!
Hi @theMr17, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
Explanation
Fixes #4042
This PR implements the success criteria metrics required for lesson checkpointing as described here. A high level overview of the implementation is documented on the issue thread here.
Changes to FakeAnalyticsEventLogger
fun getOldestEvents(count: Int): List<EventLog>
is necessary to retrieve a list of a pre-defined count of oldest events from all the logged events.fun getLoggedEvent(predicate: (EventLog) -> Boolean): EventLog?
serves to acquire a reference to a logged event when the context of the event is known, but the event index is uncertain or potentially surrounded by other events. Thus, extracting the event via index might be difficult.Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: