Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5312: Make todo open check locally runnable #5315

Merged
merged 68 commits into from
Mar 20, 2024

Commits on Aug 22, 2023

  1. Fix a variety of dev platform-specific issues.

    These issues were found after I started using a new development
    environment.
    BenHenning committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    667bf89 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Tidy some things up, and revert fragment test.

    ProfileAndDeviceIdFragmentTest had been updated to use a newer fragment
    initialization pattern, but that's no longer needed and seems to be
    causing what appears to be timing discrepancies between local dev and
    CI.
    BenHenning committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    fb59232 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Fix test behavior inconsistency in test.

    The issue ultimately arose from test parameters being initialized after
    they're needed in the launched UI. This type of change was tried earlier
    in the branch, but reverted since it didn't seem necessary. It is,
    however, necessary when there are environment differences (e.g. local
    vs. CI) or when running certain tests individually.
    
    Due to the difficulty in finding this issue, ActivityScenarioRule has
    been added as a prohibited pattern in the static regex checks (along
    with ActivityTestRule since that's deprecated and discouraged, anyway).
    BenHenning committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    2551d4b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    714f3ea View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Fix broken ProfileAndDeviceIdFragmentTest test.

    The test was suffering from some proto encoding inconsistencies that
    seem to occur between some development machines vs. on CI. The fix
    improves the test's robustness by extracting the raw encoded string,
    verifying that the other outputs in the intent message correctly
    correspond to that string, and that the string (as a parsed proto)
    contains the correct values. As a result, the test no longer depends on
    a hardcoded encoding value to be present for verification. This does
    result in a bit more logic than is generally good to have in a test (and
    it lengthened the test code quite a bit), but it seems necessary in this
    particular case.
    BenHenning committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    7488b9f View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Configuration menu
    Copy the full SHA
    e3d4091 View commit details
    Browse the repository at this point in the history
  2. Post-merge fix.

    BenHenning committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    5671673 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Configuration menu
    Copy the full SHA
    bd1466d View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Make TodoOpenCheck locally runnable.

    This does a bunch of other small things, too, but the main difference
    here is introducing support for interacting with GitHub via its REST API
    rather than requiring the user to use the 'gh' tool locally (though the
    gh CLI tool is still needed for maintaining authentication access).
    BenHenning committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    39a3add View commit details
    Browse the repository at this point in the history
  2. Simplify GitHubIssue & some static fixes/docs.

    Tests still need to be added, and some cleanup is needed once the
    branch's base is adjusted.
    BenHenning committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    4f7bfd6 View commit details
    Browse the repository at this point in the history
  3. Add ScriptBackgroundCoroutineDispatcher.

    This is a script-specific dispatcher which will allow for better
    asynchronous support in upcoming PRs (especially for command execution).
    This change serves to prepare for those changes.
    BenHenning committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    000bba3 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Some more robustness fixes.

    The main change here is ensuring that Bazel 4.0.0 is used & bzlmod
    disabled in newer versions of Bazel when running operations in a test
    Bazel environment.
    
    This commit also introduces some more timing tweaks on CommandExecutor
    for some tests, though these only affect very specific tests (as many
    script tests directly call a script's main() function and thus don't
    overwrite its executor behavior).
    
    This commit attempted to introduce "--batch" mode to runs, but the
    isolation didn't actually seem to improve stability and, instead,
    substantially slowed down some of the tests.
    BenHenning committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    79878cd View commit details
    Browse the repository at this point in the history
  2. Merge branch 'fix-platform-specific-issues' into introduce-better-scr…

    …ipt-execution-support
    
    Conflicts:
    	scripts/src/java/org/oppia/android/scripts/ci/ComputeAffectedTests.kt
    	scripts/src/javatests/org/oppia/android/scripts/ci/ComputeAffectedTestsTest.kt
    	scripts/src/javatests/org/oppia/android/scripts/common/BazelClientTest.kt
    BenHenning committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    a5f71d6 View commit details
    Browse the repository at this point in the history
  3. Post-merge fixes.

    Plus, actually makes use of the new script background dispatcher in
    CommandExecutorImpl to make the new wiring make more sense (though its
    real utility will come in a follow-up PR).
    BenHenning committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    0b55bd4 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'introduce-better-script-execution-support' into make-to…

    …do-check-locally-runnable
    BenHenning committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    53d6727 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2024

  1. Post-merge fixes & adjustments.

    This makes the TODO open check script runnable using the script
    background dispatcher, and fixes some tests so that they pass now.
    
    More documentation and testing work is still needed to finalize this PR.
    BenHenning committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    00c7c28 View commit details
    Browse the repository at this point in the history
  2. Fix BUILD file lint issue.

    BenHenning committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    bd97611 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d54829d View commit details
    Browse the repository at this point in the history
  4. Merge branch 'introduce-better-script-execution-support' into make-to…

    …do-check-locally-runnable
    BenHenning committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    fa9cae4 View commit details
    Browse the repository at this point in the history
  5. Static fix checks.

    BenHenning committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    0618b12 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Configuration menu
    Copy the full SHA
    211487c View commit details
    Browse the repository at this point in the history
  2. Post-merge fixes.

    BenHenning committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    1a666a9 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Configuration menu
    Copy the full SHA
    a2ee5d3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d5b9012 View commit details
    Browse the repository at this point in the history
  3. Fixed broken instrumentation builds.

    This was done by removing the //testing dependency and, instead, having
    instrumentation targets depend on the direct module within //testing
    that they need to build. This module & its corresponding implementation
    binding (and tests) needed to be moved out of //testing and into their
    own /firebase package.
    BenHenning committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    e6ec869 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9f50469 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8dbf4dc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9c38057 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f2ff4e3 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Add missing tests for TestBlazeWorkspace changes.

    Also includes some minor clean-ups within TestBazelWorkspaceTest.
    BenHenning committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    fad48ed View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e1802c8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    00c32f6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2f87f4d View commit details
    Browse the repository at this point in the history
  5. Merge branch 'introduce-better-script-execution-support' into make-to…

    …do-check-locally-runnable
    BenHenning committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    aa3547c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d3cbd93 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    13e4358 View commit details
    Browse the repository at this point in the history
  8. Merge branch 'introduce-better-script-execution-support' into make-to…

    …do-check-locally-runnable
    BenHenning committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    622aced View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    50f41d2 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    c8df70e View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Configuration menu
    Copy the full SHA
    c85d421 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dcf27b6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2369514 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c7ec5d4 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'introduce-better-script-execution-support' into make-to…

    …do-check-locally-runnable
    BenHenning committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    4b418bd View commit details
    Browse the repository at this point in the history
  6. Improve new test robustness.

    Required upgrade of kotlinx-coroutines-core.
    BenHenning committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    8de4d51 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3f69f11 View commit details
    Browse the repository at this point in the history
  8. Merge branch 'introduce-better-script-execution-support' into make-to…

    …do-check-locally-runnable
    BenHenning committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    ea8e0b1 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Update scripts/src/javatests/org/oppia/android/scripts/common/GitClie…

    …ntTest.kt
    
    Co-authored-by: Adhiambo Peres <[email protected]>
    BenHenning and adhiamboperes authored Feb 14, 2024
    Configuration menu
    Copy the full SHA
    2916770 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f2d810a View commit details
    Browse the repository at this point in the history
  3. Merge branch 'fix-platform-specific-issues' into introduce-better-scr…

    …ipt-execution-support
    
    Conflicts:
    	third_party/maven_install.json
    BenHenning committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    808f412 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'introduce-better-script-execution-support' into make-to…

    …do-check-locally-runnable
    BenHenning committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    2315aea View commit details
    Browse the repository at this point in the history
  5. Add tests for GitHubClient & TodoOpenCheck.

    Add new FakeCommandExecutor utility + tests.
    
    Add missing GitHub workflow update.
    BenHenning committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    af51395 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6856e3c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5a050de View commit details
    Browse the repository at this point in the history
  8. Merge branch 'introduce-better-script-execution-support' into make-to…

    …do-check-locally-runnable
    BenHenning committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    13b8d4b View commit details
    Browse the repository at this point in the history
  9. Add missing docs.

    BenHenning committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    280b3ec View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Configuration menu
    Copy the full SHA
    a5eb624 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'introduce-better-script-execution-support' into make-to…

    …do-check-locally-runnable
    BenHenning committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    ae239b3 View commit details
    Browse the repository at this point in the history
  3. Fix broken TodoOpenCheck tests & check exemptions.

    For the former, this mainly involved isolating the gh auth tool
    dependency in the same way as GitHubClientTest. This improves
    environment independence and test performance.
    BenHenning committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    34ea6aa View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Configuration menu
    Copy the full SHA
    e0e74d5 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'introduce-better-script-execution-support' into make-to…

    …do-check-locally-runnable
    BenHenning committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    2dd0cd7 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Configuration menu
    Copy the full SHA
    70df9b3 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'introduce-better-script-execution-support' into make-to…

    …do-check-locally-runnable
    BenHenning committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    04fc8b8 View commit details
    Browse the repository at this point in the history
  3. Address reviewer comment.

    BenHenning committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    c301eed View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Configuration menu
    Copy the full SHA
    51a96ce View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Merge commit 'e2f94e41e4cba3bc5b5f3af65f7c43a6543b4c52' into introduc…

    …e-better-script-execution-support
    BenHenning committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    b3e2fd9 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'introduce-better-script-execution-support' into make-to…

    …do-check-locally-runnable
    BenHenning committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    73a8bce View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f48f78e View commit details
    Browse the repository at this point in the history