Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #5025: App and OS Deprecation Milestone 4 - Gate the new Deprecation Dialogs and Add Logic to Display Them #5249

Merged

Conversation

kkmurerwa
Copy link
Collaborator

@kkmurerwa kkmurerwa commented Nov 28, 2023

Explanation

Fix part of #5025 - When this PR is merged, it will;

  • Add ability to display the new deprecation dialogs when the app-and-os-deprecation feature flag is enabled.
  • Add ability to cache previous responses so that the user is not spammed with dialogs every time they open the app.
  • Include tests for all added functionalities.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@kkmurerwa kkmurerwa requested review from a team as code owners November 28, 2023 14:11
@kkmurerwa kkmurerwa changed the title Fix part of #5025: App and OS Deprecation Milestone 3 - Add New Deprecation Dialog Fragments Fix part of #5025: App and OS Deprecation Milestone 4 - Add New Deprecation Dialog Fragments Nov 28, 2023
@kkmurerwa kkmurerwa self-assigned this Nov 28, 2023
@kkmurerwa kkmurerwa changed the title Fix part of #5025: App and OS Deprecation Milestone 4 - Add New Deprecation Dialog Fragments Fix part of #5025: App and OS Deprecation Milestone 4 - Gate the new Deprecation Dialogs and Logic to Display Them Nov 28, 2023
@kkmurerwa kkmurerwa changed the title Fix part of #5025: App and OS Deprecation Milestone 4 - Gate the new Deprecation Dialogs and Logic to Display Them Fix part of #5025: App and OS Deprecation Milestone 4 - Gate the new Deprecation Dialogs and Add Logic to Display Them Nov 28, 2023
@kkmurerwa
Copy link
Collaborator Author

Hi @adhiamboperes. This PR is ready for review. PTAL

@kkmurerwa kkmurerwa assigned adhiamboperes and unassigned kkmurerwa Dec 7, 2023
Copy link

oppiabot bot commented Dec 30, 2023

Hi @kkmurerwa, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Dec 30, 2023
@kkmurerwa kkmurerwa removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 2, 2024
Copy link

oppiabot bot commented Jan 11, 2024

Hi @kkmurerwa, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 11, 2024
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 15, 2024
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kkmurerwa!. And apologies for the delay in review.

I have left comments, I think this needs two more review passes before it is merge ready.

@kkmurerwa
Copy link
Collaborator Author

@adhiamboperes I have made a lot of changes including taking consideration of previous responses when showing the app deprecation dialog. PTAL

@oppiabot oppiabot bot assigned adhiamboperes and unassigned kkmurerwa Feb 13, 2024
Copy link

oppiabot bot commented Feb 13, 2024

Unassigning @kkmurerwa since a re-review was requested. @kkmurerwa, please make sure you have addressed all review comments. Thanks!

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kkmurerwa! left some comments especially about test formats. Please see inline.

@kkmurerwa
Copy link
Collaborator Author

@adhiamboperes I have made the suggested changes. PTAL

@oppiabot oppiabot bot assigned adhiamboperes and unassigned kkmurerwa Feb 20, 2024
Copy link

oppiabot bot commented Feb 20, 2024

Unassigning @kkmurerwa since a re-review was requested. @kkmurerwa, please make sure you have addressed all review comments. Thanks!

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kkmurerwa! This LGTM.

@BenHenning, PTAL for codeowners.

Copy link

oppiabot bot commented Feb 20, 2024

Hi @kkmurerwa, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, this doesn't seem to require any review from me. I did take a quick scan and didn't notice anything to note, so going ahead and skipping review.

Deferring to you @adhiamboperes for merging in case I missed something.

@adhiamboperes
Copy link
Collaborator

Merging this since it LGTM.

@adhiamboperes adhiamboperes merged commit 67c7a92 into oppia:develop Feb 23, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants