-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5230: VectorDrawableCompat Lint error #5235
Fix #5230: VectorDrawableCompat Lint error #5235
Conversation
@adhiamboperes PTAL |
This test is the reason for the fail "testStartOverExploration_logsStartCardAndStartOverEvents()" in the "ExplorationProgressControllerTest.kt" file. |
Good day @adhiamboperes , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @deonwaju!
I re-ran the CI, it seems like a flaky test and has now passed.
.gitignore
Outdated
gradle.properties | ||
gradle-wrapper.properties |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, Thank you very much. Ok, I will revert it immediately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reverted it @adhiamboperes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still shows 2 files changed. I'm only expecting to see app's build.gradle modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, checking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @adhiamboperes, I have tried to revert the change, but i am still having two file changes as you said. Even used rebase. I might have to advise to use a new PR branch, if you agree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deonwaju, it may be best to open a replacement PR. When creating a commit, only git add the file that has the desired changes, instead of git add .. This should be simple to do from within the android studio commit toolbar/vcs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I understand, thanks very much
@adhiamboperes PTAL |
…ror' into Fix/vectorDrawableCompat_lint_error
…ror' into Fix/vectorDrawableCompat_lint_error
Explanation
Fix #5230: VectorDrawableCompat Lint error
Warning: VectorDrawableCompat
Fix: opened the app's build.gradle file.
Inside the android block, added the vectorDrawables section under defaultConfig with the code below:
android { ... defaultConfig { ... vectorDrawables { useSupportLibrary true } } }
Essential Checklist