Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5230: VectorDrawableCompat Lint error #5235

Closed

Conversation

deonwaju
Copy link
Collaborator

@deonwaju deonwaju commented Nov 17, 2023

Explanation

Fix #5230: VectorDrawableCompat Lint error

Warning: VectorDrawableCompat
Fix: opened the app's build.gradle file.
Inside the android block, added the vectorDrawables section under defaultConfig with the code below:
android { ... defaultConfig { ... vectorDrawables { useSupportLibrary true } } }

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

@deonwaju deonwaju requested a review from a team as a code owner November 17, 2023 11:50
@deonwaju deonwaju requested a review from a team as a code owner November 17, 2023 14:33
@deonwaju
Copy link
Collaborator Author

@adhiamboperes PTAL

@deonwaju
Copy link
Collaborator Author

This test is the reason for the fail "testStartOverExploration_logsStartCardAndStartOverEvents()" in the "ExplorationProgressControllerTest.kt" file.

@deonwaju
Copy link
Collaborator Author

deonwaju commented Nov 20, 2023

Good day @adhiamboperes ,
Please, I need help here. So I can move on to the next tasks.

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deonwaju!

I re-ran the CI, it seems like a flaky test and has now passed.

.gitignore Outdated
Comment on lines 28 to 29
gradle.properties
gradle-wrapper.properties
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, Thank you very much. Ok, I will revert it immediately

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reverted it @adhiamboperes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still shows 2 files changed. I'm only expecting to see app's build.gradle modified.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, checking

Copy link
Collaborator Author

@deonwaju deonwaju Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adhiamboperes, I have tried to revert the change, but i am still having two file changes as you said. Even used rebase. I might have to advise to use a new PR branch, if you agree.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deonwaju, it may be best to open a replacement PR. When creating a commit, only git add the file that has the desired changes, instead of git add .. This should be simple to do from within the android studio commit toolbar/vcs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I understand, thanks very much

@deonwaju
Copy link
Collaborator Author

@adhiamboperes PTAL

@oppiabot oppiabot bot assigned adhiamboperes and unassigned deonwaju Nov 20, 2023
Copy link

oppiabot bot commented Nov 20, 2023

Unassigning @deonwaju since a re-review was requested. @deonwaju, please make sure you have addressed all review comments. Thanks!

@deonwaju deonwaju closed this Nov 21, 2023
@deonwaju deonwaju deleted the Fix/vectorDrawableCompat_lint_error branch November 21, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VectorDrawableCompat
2 participants