Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2882: Build bazel for util/profile #2915

Merged
merged 5 commits into from
Mar 20, 2021
Merged

Fix #2882: Build bazel for util/profile #2915

merged 5 commits into from
Mar 20, 2021

Conversation

Victor-Titan
Copy link
Contributor

@Victor-Titan Victor-Titan commented Mar 15, 2021 •
edited
Loading

Explanation

Fixes #2882

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@Victor-Titan
Built BUILD.bazel file for utility/profile folder. Added the director…
63569c2 
…y to the MIGRATED_PROD_FILES of the utility module's root BUILD.bazel file. Added the libraries to the list of deps dependencies in the targets that require the library
@Victor-Titan
Copy link
Contributor Author

@BenHenning @fsharpasharp PTAL

fsharpasharp
fsharpasharp suggested changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@fsharpasharp fsharpasharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Added two small comments.

fsharpasharp
fsharpasharp reviewed Mar 15, 2021
View reviewed changes
utility/src/main/java/org/oppia/android/util/profile/BUILD.bazel Show resolved Hide resolved
utility/BUILD.bazel Outdated
@@ -41,6 +42,7 @@ kt_android_library(
"//third_party:com_github_bumptech_glide_glide",
"//third_party:com_google_guava_guava",
"//third_party:org_jetbrains_kotlinx_kotlinx-coroutines-core",
"//utility/src/main/java/org/oppia/android/util/profile:directory_management_util",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're eventually going to remove this library. If possible, try to add this dependency closer to where it is used.

I see two files that depend on it, not including the test, in the domain and the data modules.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fsharpasharp So should I add this in the BUILD.bazel files of the domain and data modules? I think that will make sure no issues occur when the library is removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sounds good and remove directory_management_util from this list of dependencies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fsharpasharp PTAL now, I've done the necessary changes. I forgot to tag you.

@Victor-Titan
Copy link
Contributor Author

@BenHenning I'm seeing a lot of test failures for maven-dagger and it all points to something regarding jcenter and chaos-pinview. Should we create an issue for this? Seems like another round of flaky tests.

@Victor-Titan
Added the dependency in the bazel files of modules that used the pack…
da014e1 
…age and removed it from the utility/BUILD.bazel file.
BenHenning
BenHenning approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Victor-Titan! Just one nit comment, otherwise this LGTM.

utility/src/main/java/org/oppia/android/util/profile/BUILD.bazel Outdated Show resolved Hide resolved
@Victor-Titan
Copy link
Contributor Author

@fsharpasharp PTAL

@BenHenning
Copy link
Member

BenHenning commented Mar 20, 2021 •
edited
Loading

Ah @Victor-Titan sorry I missed your earlier issue. JCenter was having some outages a few days ago, but I did file #2923 to eventually move off of it.

BenHenning
BenHenning approved these changes Mar 20, 2021
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Victor-Titan! LGTM.

@BenHenning
Copy link
Member

Gradle failure looks like #2844. Restarting & enabling auto-merge.

@BenHenning BenHenning enabled auto-merge (squash) March 20, 2021 03:03
@BenHenning BenHenning merged commit 0a374bd into oppia:develop Mar 20, 2021
@Victor-Titan Victor-Titan deleted the build-bazel-utility-profile branch March 20, 2021 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsharpasharp fsharpasharp fsharpasharp approved these changes

@BenHenning BenHenning BenHenning approved these changes

Assignees

@BenHenning BenHenning

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a BUILD.bazel file for the profile package in the utility module
3 participants
@Victor-Titan @BenHenning @fsharpasharp