Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2734: Jcenter migration #2733

Closed
wants to merge 4 commits into from

Conversation

anandwana001
Copy link
Contributor

@anandwana001 anandwana001 commented Feb 17, 2021

Explanation

Fix #2734
How Gradle fetches dependencies - google() -> jcentre()
jcenter is a superset of Maven Central so if it doesn't found any artifact then it will fetch from Maven Central.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@anandwana001 anandwana001 changed the title Jcenter migration Fix #2734: Jcenter migration Feb 17, 2021
@@ -5,7 +5,7 @@ buildscript {
ext.fragment_version = '1.2.0-rc01'
repositories {
google()
jcenter()
mavenCentral()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given #2735 is this actually a superset?

@anandwana001 anandwana001 self-assigned this Feb 17, 2021
@BenHenning BenHenning added the PR don't merge - NEEDS UPDATE Corresponds to PRs that need to be updated with the latest develop changes before they can be merged label Feb 24, 2021
@BenHenning BenHenning removed the PR don't merge - NEEDS UPDATE Corresponds to PRs that need to be updated with the latest develop changes before they can be merged label Feb 24, 2021
@anandwana001
Copy link
Contributor Author

Closing this PR as there is a master tracker issue created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JCenter Migration
2 participants