Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix affected target computation breaking CI workflows when no targets are affected #2696

Merged
merged 11 commits into from
Feb 13, 2021
Merged

Fix affected target computation breaking CI workflows when no targets are affected #2696

merged 11 commits into from
Feb 13, 2021

Commits on Feb 12, 2021

  1. See if the extra newline is the source of issue.

    @BenHenning
    BenHenning committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    af96e06 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2021

  1. Merge branch 'develop' into fix-incorrect-affected-target-handling-wh… 

    …en-empty
    @BenHenning
    BenHenning committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    f5f0b18 View commit details
    Browse the repository at this point in the history

  2. Temporarily disable unrelated checks.

    @BenHenning
    BenHenning committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    b926a71 View commit details
    Browse the repository at this point in the history

  3. Conditionally run tests. 

    While Bazel can run an empty list of tests, GitHub actions always
expects at least 1 entry for matrix-dependent actions.

This is based on
https://github.community/t/empty-matrix-fails-workflow/128736/2. It's
not yet clear if this will properly allow check_test_results to pass if
the workflow is skipped. That will need to be tested.
    @BenHenning
    BenHenning committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    72d6f7a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into fix-incorrect-affected-target-handling-wh… 

    …en-empty
    @BenHenning
    BenHenning authored Feb 13, 2021
    Configuration menu
    Copy the full SHA
    679fbd3 View commit details
    Browse the repository at this point in the history

  5. Fix Bash syntax error.

    @BenHenning
    BenHenning committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    c177ab4 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'fix-incorrect-affected-target-handling-when-empty' of g… 

    …ithub.com:oppia/oppia-android into fix-incorrect-affected-target-handling-when-empty
    @BenHenning
    BenHenning committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    f9ef67d View commit details
    Browse the repository at this point in the history

  7. Update test results job to pass without tests run.

    @BenHenning
    BenHenning committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    2ca93a1 View commit details
    Browse the repository at this point in the history

  8. Update main.yml 

    Reenable jobs.
    @BenHenning
    BenHenning authored Feb 13, 2021
    Configuration menu
    Copy the full SHA
    e7b5d20 View commit details
    Browse the repository at this point in the history

  9. Update compute_affected_tests.sh 

    Undo removing the newline since it's not actually needed.
    @BenHenning
    BenHenning authored Feb 13, 2021
    Configuration menu
    Copy the full SHA
    3d5758c View commit details
    Browse the repository at this point in the history

  10. Re-remove newline since it is needed. 

    I forgot that we're performing an empty check, so the extra newline does
break it.
    @BenHenning
    BenHenning committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    c0c46bf View commit details
    Browse the repository at this point in the history