Skip to content

[#48274] Work packages export modal with settings & Job status modal #93

[#48274] Work packages export modal with settings & Job status modal

[#48274] Work packages export modal with settings & Job status modal #93

GitHub Actions / rubocop succeeded Aug 22, 2024 in 0s

reviewdog [rubocop] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (93)

app/controllers/work_packages_controller.rb|154 col 18| Use safe navigation (&.) instead of checking if an object exists before calling the method.
app/helpers/work_packages_controller_helper.rb|44 col 82| Do not use instance variables in helpers.
app/helpers/work_packages_controller_helper.rb|56 col 31| Do not use instance variables in helpers.
app/helpers/work_packages_controller_helper.rb|57 col 5| Do not use instance variables in helpers.
app/helpers/work_packages_controller_helper.rb|59 col 12| Do not use instance variables in helpers.
app/helpers/work_packages_controller_helper.rb|62 col 27| Do not use instance variables in helpers.
app/helpers/work_packages_controller_helper.rb|69 col 17| Do not use instance variables in helpers.
app/helpers/work_packages_controller_helper.rb|70 col 27| Do not use instance variables in helpers.
app/models/project.rb|49 col 3| Specify a :dependent option.
app/models/project.rb|49 col 3| Specify an :inverse_of option.
app/models/project.rb|57 col 3| Specify a :dependent option.
app/models/project.rb|58 col 3| Specify a :dependent option.
app/models/project.rb|58 col 3| Specify an :inverse_of option.
app/models/project.rb|65 col 3| Prefer has_many :through to has_and_belongs_to_many.
app/models/project.rb|68 col 3| Specify a :dependent option.
app/models/project.rb|68 col 3| Specify an :inverse_of option.
app/models/project.rb|73 col 3| Specify an :inverse_of option.
app/models/project.rb|79 col 3| Specify an :inverse_of option.
app/models/project.rb|80 col 3| Specify an :inverse_of option.
app/models/project.rb|81 col 3| Specify an :inverse_of option.
app/models/queries/filters/shared/custom_fields/base.rb|100 col 9| Use <<-SQL.squish instead of <<-SQL.
app/models/work_package/pdf_export/work_package_list_to_pdf.rb|108 col 3| Assignment Branch Condition size for render_work_packages_pdfs is too high. [<0, 15, 9> 17.49/17]
app/models/work_package/pdf_export/work_package_list_to_pdf.rb|108 col 3| Perceived complexity for render_work_packages_pdfs is too high. [10/8]
app/workers/backup_job.rb|157 col 3| Assignment Branch Condition size for create_backup_archive! is too high. [<7, 15, 4> 17.03/17]
lib/api/v3/work_packages/work_package_collection_representer.rb|83 col 38| Use safe navigation (&.) instead of checking if an object exists before calling the method.
modules/bim/spec/features/bcf/export_spec.rb|90 col 5| Avoid instance variables - use let, a method call, or a local variable (if possible).
modules/bim/spec/features/bcf/export_spec.rb|94 col 7| Avoid instance variables - use let, a method call, or a local variable (if possible).
modules/job_status/app/workers/job_status/application_job_with_status.rb|62 col 5| Assignment Branch Condition size for upsert_status is too high. [<5, 18, 2> 18.79/17]
modules/xls_export/app/models/xls_export/work_package/exporter/xls.rb|63 col 7| Use normalcase for variable numbers.
modules/xls_export/app/models/xls_export/work_package/exporter/xls.rb|64 col 9| Use Array.new(columns.size) with a block instead of .times.map only if columns.size is always 0 or more.
modules/xls_export/app/models/xls_export/work_package/exporter/xls.rb|87 col 10| Use !empty? instead of size > 0.
modules/xls_export/app/models/xls_export/work_package/exporter/xls.rb|144 col 35| Prefer exists?(id: other.id) over where(id: other.id).exists?.
modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb|44 col 9| Use normalcase for symbol numbers.
modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb|47 col 9| Use normalcase for symbol numbers.
modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb|72 col 5| Do not define constants this way within a block.
modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb|72 col 5| Stub constant instead of declaring explicitly.
modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb|73 col 5| Do not define constants this way within a block.
modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb|73 col 5| Stub constant instead of declaring explicitly.
modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb|74 col 5| Do not define constants this way within a block.
modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb|74 col 5| Stub constant instead of declaring explicitly.
modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb|75 col 5| Do not define constants this way within a block.
modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb|75 col 5| Stub constant instead of declaring explicitly.
modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb|76 col 5| Do not define constants this way within a block.
modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb|76 col 5| Stub constant instead of declaring explicitly.
modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb|77 col 5| Do not define constants this way within a block.
modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb|77 col 5| Stub constant instead of declaring explicitly.
modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb|78 col 5| Do not define constants this way within a block.
modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb|78 col 5| Stub constant instead of declaring explicitly.
modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb|79 col 5| Do not define constants this way within a block.
modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb|79 col 5| Stub constant instead of declaring explicitly.
modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb|81 col 5| Example has too many lines. [45/25]
modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb|81 col 5| Example has too many expectations [23/15].
modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb|148 col 131| Line is too long. [133/130]
spec/features/admin/backup_spec.rb|51 col 13| Avoid instance variables - use let, a method call, or a local variable (if possible).
spec/features/admin/backup_spec.rb|89 col 7| Do not use expect in before hook
spec/features/admin/backup_spec.rb|105 col 32| Prefer string interpolation to string concatenation.
spec/features/projects/template_spec.rb|143 col 20| Shadowing outer local variable - mail.
spec/features/work_packages/bulk/move_work_package_spec.rb|78 col 9| Do not use expect in before hook
spec/features/work_packages/bulk/move_work_package_spec.rb|84 col 9| Do not use expect in before hook
spec/lib/api/v3/work_packages/work_package_collection_representer_spec.rb|512 col 24| Avoid using OpenStruct; use Struct, Hash, a class or test doubles instead.
spec/lib/api/v3/work_packages/work_package_collection_representer_spec.rb|603 col 40| Do not use String#to_time without zone. Use Time.zone.parse instead.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|136 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|145 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|154 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|163 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|172 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|181 col 5| Repeated context block description on line(s) [190]
spec/models/queries/projects/filters/custom_field_filter_spec.rb|181 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|190 col 5| Repeated context block description on line(s) [181]
spec/models/queries/projects/filters/custom_field_filter_spec.rb|190 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|199 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|208 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|226 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|235 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|244 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|253 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|262 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|276 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|290 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|299 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|309 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|321 col 7| Add an empty line after the last let.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|400 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|406 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|412 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|418 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|424 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|453 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|483 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/queries/projects/filters/custom_field_filter_spec.rb|489 col 13| Context description should match /^and\b/, /^as\b/, /^even\b/, /^for\b/, /^given\b/, /^having\b/, /^if\b/, /^in\b/, /^on\b/, /^to\b/, /^unless\b/, /^via\b/, /^when\b/, /^with\b/, /^within\b/, or /^without\b/.
spec/models/work_package/exporter/csv_integration_spec.rb|31 col 1| Spec path should end with work_package/exports/csv*_spec.rb.
spec/models/work_packages/pdf_export/work_package_list_to_pdf_gantt_spec.rb|56 col 1| Spec path should end with work_package/pdf_export/work_package_list_to_pdf*_spec.rb.
spec/models/work_packages/pdf_export/work_package_list_to_pdf_spec.rb|31 col 1| Spec path should end with work_package/pdf_export/work_package_list_to_pdf*_spec.rb.