Skip to content

remove explicit project column from notifications #68

remove explicit project column from notifications

remove explicit project column from notifications #68

GitHub Actions / rubocop succeeded Aug 21, 2024 in 0s

reviewdog [rubocop] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (24)

app/mailers/digest_mailer.rb|54 col 3| Assignment Branch Condition size for work_packages is too high. [<5, 17, 4> 18.17/17]
spec/contracts/notifications/create_contract_spec.rb|36 col 5| Empty block detected.
spec/features/notifications/navigation_spec.rb|49 col 7| Useless assignment to variable - wp_full.
spec/models/journal_spec.rb|33 col 14| Use described_class instead of Journal.
spec/models/queries/notifications/notification_query_spec.rb|72 col 26| Use expect(...).not_to be_valid.
spec/models/queries/notifications/notification_query_spec.rb|92 col 26| Use expect(...).not_to be_valid.
spec/models/queries/notifications/notification_query_spec.rb|160 col 26| Use expect(...).not_to be_valid.
spec/models/queries/notifications/notification_query_spec.rb|219 col 26| Use expect(...).not_to be_valid.
spec/requests/api/v3/notifications/bulk_read_ian_resource_spec.rb|30 col 1| Spec path should end with api/v3/notifications/notifications_api*_spec.rb.
spec/requests/api/v3/notifications/bulk_read_ian_resource_spec.rb|65 col 7| Prefer expect(last_response).to have_http_status(204) over expect(last_response.status) .to be(204).
spec/requests/api/v3/notifications/bulk_read_ian_resource_spec.rb|113 col 9| Prefer expect(last_response).to have_http_status(400) over expect(last_response.status) .to be(400).
spec/requests/api/v3/notifications/bulk_unread_ian_resource_spec.rb|30 col 1| Spec path should end with api/v3/notifications/notifications_api*_spec.rb.
spec/requests/api/v3/notifications/bulk_unread_ian_resource_spec.rb|74 col 7| Prefer expect(last_response).to have_http_status(204) over expect(last_response.status) .to be(204).
spec/requests/api/v3/notifications/bulk_unread_ian_resource_spec.rb|122 col 9| Prefer expect(last_response).to have_http_status(400) over expect(last_response.status) .to be(400).
spec/requests/api/v3/notifications/details_resource_spec.rb|30 col 1| Spec path should end with api/v3/notifications/notifications_api*_spec.rb.
spec/requests/api/v3/notifications/index_resource_spec.rb|31 col 1| Spec path should end with api/v3/notifications/notifications_api*_spec.rb.
spec/requests/api/v3/notifications/index_resource_spec.rb|202 col 11| Prefer expect(last_response).to have_http_status(400) over expect(last_response.status) .to be 400.
spec/requests/api/v3/notifications/index_resource_spec.rb|224 col 11| Prefer expect(last_response).to have_http_status(400) over expect(last_response.status) .to be 400.
spec/requests/api/v3/notifications/read_ian_resource_spec.rb|30 col 1| Spec path should end with api/v3/notifications/notifications_api*_spec.rb.
spec/requests/api/v3/notifications/show_resource_spec.rb|31 col 1| Spec path should end with api/v3/notifications/notifications_api*_spec.rb.
spec/services/notifications/set_attributes_service_spec.rb|34 col 16| Prefer using verifying doubles over normal doubles.
spec/services/notifications/set_attributes_service_spec.rb|44 col 5| Prefer using verifying doubles over normal doubles.
spec/services/notifications/set_attributes_service_spec.rb|48 col 5| Prefer using verifying doubles over normal doubles.
spec/services/notifications/set_attributes_service_spec.rb|140 col 19| Prefer have_received for setting message expectations. Setup event as a spy using allow or instance_spy.