Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Pattern input field (the alternative version) #17634

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

brunopagno
Copy link
Contributor

@brunopagno brunopagno commented Jan 16, 2025

Ticket

https://community.openproject.org/projects/document-workflows-stream/work_packages/59999

Strongly related to #17472

Screenshots

Screencast.From.2025-01-24.09-52-20.mp4

What approach did you choose and why?

The difference of this approach is that it behaves even more like a text editor with an autocomplete (e.g. code editor) than a legitimate autocomplete field.

  • Tokens are editable and do validation if they are representative of a valid value or not
  • We do not validate tokens in this PR, so they can be submitted with invalid values

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@lindenthal
Copy link
Member

Hi @dominic-braeunlein,
I just tried to create a pullpreview environment. The build seems not to be started. Can you please check?
Thanks
Niels

@brunopagno brunopagno force-pushed the impl/59999-patterninput-reduced branch from c52bc26 to 08a116d Compare January 22, 2025 17:37
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17634 January 22, 2025 17:38 Inactive
@brunopagno brunopagno force-pushed the impl/59999-patterninput-reduced branch from 08a116d to 8dc5525 Compare January 23, 2025 16:17
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17634 January 23, 2025 16:18 Inactive
@dominic-braeunlein
Copy link
Contributor

Hi @dominic-braeunlein, I just tried to create a pullpreview environment. The build seems not to be started. Can you please check? Thanks Niels

FYI: Pull-preview is deployed

@lindenthal

@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17634 January 24, 2025 08:07 Inactive
This commit introduces a new type of input field which can handle autocomplete with 'tokens', so that we can build
patterns like `Example pattern {{token}} value`.
@brunopagno brunopagno force-pushed the impl/59999-patterninput-reduced branch from 142e33d to 21b788b Compare January 24, 2025 08:12
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17634 January 24, 2025 08:19 Inactive
@brunopagno brunopagno marked this pull request as ready for review January 24, 2025 08:52
@brunopagno brunopagno requested review from HDinger and a team January 24, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants