Ldap sync not lock users OP#60566 #17581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/projects/openproject/work_packages/60566/activity
What are you trying to accomplish?
The goal is to resolve a bug in the
ldap_users_sync_statusfeature where inactive users are not disabled during synchronization. The issue arises due to a .map operation being executed on anilobject, causing the process to fail.What approach did you choose and why?
The chosen approach is to add a safeguard for the
.mapoperation, ensuring it handles nil values gracefully. This eliminates the error and restores the intended functionality of disabling inactive users during LDAP sync.Merge checklist