[#58337] use correct link attachment upload #17018
Open
+59
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For this kind of bug, it sounds like a good idea to add a spec to it. Could you please add one to make sure it's regression-safe? 🙏 |
- https://community.openproject.org/work_packages/58337 - use `addAttachment` link as an upload target, if no direct upload is specified - before was `attachments` link, which is conditionally hidden
- now the ckeditor instance of a custom text widget in a grid has access to the correct attachments link
Kharonus
force-pushed
the
bug/58337-inserted-images-are-lost-when-the-show-attachments-in-the-work-packages-files-tab-is-off
branch
from
691f940
to
230263f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
OP#58337
What are you trying to accomplish?
What approach did you choose and why?
addAttachmentlink as an upload target, if no direct upload is specified - before wasattachmentslink, which is conditionally hidden