Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy project background color in dark mode #16499

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

Eric-Guo
Copy link
Contributor

What are you trying to accomplish?

Fix the dark mode display in copy project screen.

Screenshots

Before this PR

Light mode

image

Dark mode

image

After apply this PR

Light mode

image

Dark mode

image

What approach did you choose and why?

Using primer design system color.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Safari 17.6 and Chrome 128)

Copy link
Contributor

@HDinger HDinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks a lot 🙇

@HDinger HDinger merged commit 6d9a55e into opf:dev Aug 28, 2024
8 checks passed
@Eric-Guo Eric-Guo deleted the copy_project_background branch August 28, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants